build: update to nodejs rules 0.41.0 - #33996
Closed
gregmagolan wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Nov 24, 2019
gregmagolan
marked this pull request as ready for review
November 24, 2019 17:34
Copy link
Copy Markdown
Contributor
Author
|
Note: protractor data work-around in this PR can be removed after this bazel-contrib/rules_nodejs#1388 lands and makes it into the next release. |
Sorry, something went wrong.
Comment thread
modules/playground/e2e_test/sourcemap/BUILD.bazel
Outdated
petebacondarwin
approved these changes
Nov 25, 2019
josephperrott
approved these changes
Nov 25, 2019
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
modules/playground/src/web_workers/images/index.html
Outdated
josephperrott
approved these changes
Nov 25, 2019
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, global approval
Sorry, something went wrong.
This bring is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0. rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests. Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.
Copy link
Copy Markdown
Member
|
Caretaker note: Global Approval |
Sorry, something went wrong.
mhevery
pushed a commit
that referenced
this pull request
Nov 27, 2019
This bring is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0. rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests. Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web. PR Close #33996
mhevery
pushed a commit
that referenced
this pull request
Nov 27, 2019
mhevery
pushed a commit
that referenced
this pull request
Nov 27, 2019
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings is changes to the @nodejs repository required for #33927. See release notes for more details: https://github.com/bazelbuild/rules_nodejs/releases/tag/0.41.0.
rules_nodejs is approaching 1.0 and breaking changes for that release are being made more frequently. In this release, the ts_devserver API changed and it no longer injects html script tags into a provided index.html file. The diff on this commit is large as this breaking change affects quite a few tests.
Also note that we don’t update @angular/bazel schematics and integration/bazel as 0.41.0 is not a recommended update for angular end-users yet due to the breaking changes in ts_devserver & web_package (now named pkg_web). When a suitable plain npm package that is in progress is finished then it will be possible to easily replace the html injection functionality removed from ts_devserver & pkg_web.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information