build(docs-infra): do not include CI-specific config in docs examples ZIP archives - #36018
Closed
gkalpak wants to merge 2 commits into
Closed
build(docs-infra): do not include CI-specific config in docs examples ZIP archives#36018gkalpak wants to merge 2 commits into
gkalpak wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
You can preview a4069c2 at https://pr36018-a4069c2.ngbuilds.io/. |
Sorry, something went wrong.
The `removeSystemJsConfig` and `type` properties (present in some `zipper.json` files) are now obsolete and are not taken into account by the example zipper: - `removeSystemJsConfig` is no longer relevant since most examples have been migrated to use the CLI. - `type` is no longer relevant, because the project type is determined based on the `projectType` property in `example-config.json` files. This commit removes these properties from `zipper.json` files and updates the `example-zipper` docs to not mention them.
… ZIP archives In angular#35381, a new Protractor config file was introduced in docs examples, `protractor-puppeteer.conf.js`, that was only supposed to be used on CI and not be shipped with the ZIP archives provided for users to download and experiment with the docs examples locally. The logic to ignore the `protractor-puppeteer.conf.js` file was incorrect, resulting in the file being retained in some examples (e.g. [universal][1]). The problem was not immediately obvious, because most examples explicitly specify all `**/*.js` files as ignored, but for other examples the file was retained in the ZIP archive. This commit fixes the logic to ensure the file is excluded from all docs examples ZIP archives. [1]: https://v9.angular.io/generated/zips/universal/universal.zip
gkalpak
force-pushed
the
build-aio-exclude-protractor-ci-config
branch
from
a4069c2 to
fd45beb
Compare
March 16, 2020 14:36
Copy link
Copy Markdown
|
You can preview fd45beb at https://pr36018-fd45beb.ngbuilds.io/. |
Sorry, something went wrong.
AndrewKushnir
approved these changes
Mar 16, 2020
petebacondarwin
approved these changes
Mar 18, 2020
IgorMinar
approved these changes
Mar 24, 2020
Copy link
Copy Markdown
Contributor
|
lgtm - global approval |
Sorry, something went wrong.
alxhub
pushed a commit
that referenced
this pull request
Mar 27, 2020
#36018) The `removeSystemJsConfig` and `type` properties (present in some `zipper.json` files) are now obsolete and are not taken into account by the example zipper: - `removeSystemJsConfig` is no longer relevant since most examples have been migrated to use the CLI. - `type` is no longer relevant, because the project type is determined based on the `projectType` property in `example-config.json` files. This commit removes these properties from `zipper.json` files and updates the `example-zipper` docs to not mention them. PR Close #36018
alxhub
pushed a commit
that referenced
this pull request
Mar 27, 2020
… ZIP archives (#36018) In #35381, a new Protractor config file was introduced in docs examples, `protractor-puppeteer.conf.js`, that was only supposed to be used on CI and not be shipped with the ZIP archives provided for users to download and experiment with the docs examples locally. The logic to ignore the `protractor-puppeteer.conf.js` file was incorrect, resulting in the file being retained in some examples (e.g. [universal][1]). The problem was not immediately obvious, because most examples explicitly specify all `**/*.js` files as ignored, but for other examples the file was retained in the ZIP archive. This commit fixes the logic to ensure the file is excluded from all docs examples ZIP archives. [1]: https://v9.angular.io/generated/zips/universal/universal.zip PR Close #36018
alxhub
pushed a commit
that referenced
this pull request
Mar 27, 2020
… ZIP archives (#36018) In #35381, a new Protractor config file was introduced in docs examples, `protractor-puppeteer.conf.js`, that was only supposed to be used on CI and not be shipped with the ZIP archives provided for users to download and experiment with the docs examples locally. The logic to ignore the `protractor-puppeteer.conf.js` file was incorrect, resulting in the file being retained in some examples (e.g. [universal][1]). The problem was not immediately obvious, because most examples explicitly specify all `**/*.js` files as ignored, but for other examples the file was retained in the ZIP archive. This commit fixes the logic to ensure the file is excluded from all docs examples ZIP archives. [1]: https://v9.angular.io/generated/zips/universal/universal.zip PR Close #36018
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #35381, a new Protractor config file was introduced in docs examples, protractor-puppeteer.conf.js, that was only supposed to be used on CI and not be shipped with the ZIP archives provided for users to download and experiment with the docs examples locally.
The logic to ignore the protractor-puppeteer.conf.js file was incorrect, resulting in the file being retained in some examples (e.g. universal). The problem was not immediately obvious, because most examples explicitly specify all **/*.js files as ignored, but for other examples the file was retained in the ZIP archive.
This commit fixes the logic to ensure the file is excluded from all docs examples ZIP archives.
This PR also cleans up obsolete properties from zipper.json files.
See individual commit messages for more info.
Jira issue: FW-1992