FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: remove solution style tsconfig by alan-agius4 · Pull Request #38394 · angular/angular · GitHub

  1. angular
  2. angular

Repository navigation

docs: remove solution style tsconfig - #38394

Closed
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:solution-tsconfig
ConversationCommits (1)ChecksFiles changed
Closed

docs: remove solution style tsconfig#38394
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:solution-tsconfig

Conversation

alan-agius4 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

Following the issues highlighted in
https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing
and discussions held with the TypeScript team.
Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

See: angular/angular-cli#18478

alan-agius4 added comp: docs state: blocked target: major This PR is targeted for the next major release labels Aug 10, 2020
ngbot Bot modified the milestone: needsTriage Aug 10, 2020
alan-agius4 changed the title docs: remove solution style tscconfig docs: remove solution style tsconfig Aug 10, 2020
docs: remove solution style tsconfig
464cb3c 
Following the issues highlighted in
https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing
and discussions held with the TypeScript team.
Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

See: angular/angular-cli#18478

alan-agius4 commented Aug 10, 2020

Copy link
Copy Markdown
Contributor Author

Blocked until angular/angular-cli#18478 is merged.

alan-agius4 added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 10, 2020

mary-poppins commented Aug 10, 2020

Copy link
Copy Markdown

You can preview 464cb3c at https://pr38394-464cb3c.ngbuilds.io/.

alan-agius4 commented Aug 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@kyliau & @clydin FYI

jelbourn approved these changes Aug 10, 2020
View reviewed changes

jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Reviewed-for: docs-packaging-and-releasing

aikithoughts approved these changes Aug 10, 2020
View reviewed changes

aikithoughts left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks like it reverts the changes back to where they were in v9, which seems correct. LGTM.

Reviewed-for: global-docs-approvers

d-koppenhagen mentioned this pull request Aug 11, 2020
Open
alan-agius4 removed the request for review from alxhub August 11, 2020 21:37
alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 11, 2020
alan-agius4 deleted the solution-tsconfig branch August 12, 2020 06:03
mahmoudajawad mentioned this pull request Aug 12, 2020
Closed
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
docs: remove solution style tsconfig (angular#38394)
6df11a9 
Following the issues highlighted in
https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing
and discussions held with the TypeScript team.
Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

See: angular/angular-cli#18478

PR Close angular#38394

angular-automatic-lock-bot Bot commented Sep 12, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

mgechev mgechev approved these changes
+3 more reviewers
jelbourn jelbourn approved these changes
kyliau kyliau approved these changes
aikithoughts aikithoughts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL