feat(core): Set default Component changeDetection strategy to OnPush - #67687
Merged
leonsenft merged 1 commit intoMar 24, 2026
Merged
feat(core): Set default Component changeDetection strategy to OnPush#67687leonsenft merged 1 commit into
leonsenft merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JeanMeche
force-pushed
the
onpush-default
branch
from
07b5578 to
285c08f
Compare
March 13, 2026 22:39
JeanMeche
force-pushed
the
onpush-default
branch
14 times, most recently
from
a4939c4 to
2cab6fa
Compare
March 16, 2026 09:18
JeanMeche
force-pushed
the
onpush-default
branch
2 times, most recently
from
c6d76e2 to
c42c696
Compare
March 21, 2026 01:48
JeanMeche
marked this pull request as ready for review
March 23, 2026 02:21
JeanMeche
force-pushed
the
onpush-default
branch
from
c42c696 to
3b3255a
Compare
March 23, 2026 02:22
JeanMeche
force-pushed
the
onpush-default
branch
from
3b3255a to
aa57f44
Compare
March 23, 2026 02:25
JeanMeche
commented
Mar 23, 2026
Comment thread
packages/compiler/src/render3/view/compiler.ts
| if ( | ||
| typeof meta.changeDetection === 'number' && | ||
| meta.changeDetection !== core.ChangeDetectionStrategy.Default | ||
| meta.changeDetection !== core.ChangeDetectionStrategy.OnPush |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I'm highlighting the main changes
1.
Sorry, something went wrong.
JeanMeche
commented
Mar 23, 2026
Comment thread
packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_component_linker_1.ts
Comment on lines
107
to
+249
| @@ -242,7 +244,9 @@ export class PartialComponentLinkerVersion1<TStatement, TExpression> | |||
| : ViewEncapsulation.Emulated, | |||
| changeDetection: metaObj.has('changeDetection') | |||
| ? parseChangeDetectionStrategy(metaObj.getValue('changeDetection')) | |||
| : ChangeDetectionStrategy.Default, | |||
| : hasOnPushByDefault | |||
| ? ChangeDetectionStrategy.OnPush | |||
| : ChangeDetectionStrategy.Eager, | |||
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Sorry, something went wrong.
JeanMeche
commented
Mar 23, 2026
Comment thread
packages/compiler/src/jit_compiler_facade.ts
| animations: decl.animations !== undefined ? new WrappedNodeExpr(decl.animations) : null, | ||
| defer, | ||
| changeDetection: decl.changeDetection ?? ChangeDetectionStrategy.Default, | ||
| changeDetection: decl.changeDetection ?? ChangeDetectionStrategy.OnPush, |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Sorry, something went wrong.
The default change detection strategy is now OnPush. BREAKING CHANGE: Component with undefined `changeDetection` property are now `OnPush` by default. Specify `changeDetection: ChangeDetectionStrategy.Eager` to keep the previous behavior.
JeanMeche
force-pushed
the
onpush-default
branch
from
aa57f44 to
e2ba6fc
Compare
March 24, 2026 01:01
josephperrott
approved these changes
Mar 24, 2026
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
Sorry, something went wrong.
alan-agius4
approved these changes
Mar 24, 2026
alan-agius4
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
Sorry, something went wrong.
alxhub
approved these changes
Mar 24, 2026
Copy link
Copy Markdown
Member
Author
|
Caretaker note: Presubmit is a flake this is good to go |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default change detection strategy is now OnPush.
BREAKING CHANGE: Component with undefined changeDetection property are now OnPush by default. Specify changeDetection: ChangeDetectionStrategy.Eager to keep the previous behavior.