Support inline TCBs in language service - #68454
Closed
atscott wants to merge 5 commits into
Closed
Conversation
atscott
force-pushed
the
inlineTemplateExternalCopy-language-service
branch
7 times, most recently
from
877f10d to
b9f2673
Compare
May 5, 2026 18:24
Langauge service previously never compiled non-exported classes. This avoided issues where test modules would cause diagnostic noise due to components appearing in declarations of two modules, for example. This change updates the logic to ensure non-exported, but standalone classes _are_ still compiled. fixes angular#65515
…e typecheck blocks This change updates the language service to generate TCBs for templates that would previously have required inlining. The new strategy is to copy the original source and then do inlining in the external TCB. This allows language features and type-checking in templates of non-exported classes (such as test components) or classes with local, non exported dependencies.
atscott
force-pushed
the
inlineTemplateExternalCopy-language-service
branch
from
b9f2673 to
46c57d9
Compare
May 5, 2026 18:28
atscott
marked this pull request as ready for review
May 5, 2026 20:13
Ensure paths are normalized before comparison and key generation in tcb_adapter.ts to avoid failures on Windows. Ensure a newline before appending imports in TypeCheckFile.render to prevent trailing comments from neutralizing them.
crisbeto
reviewed
May 6, 2026
Comment thread
packages/compiler-cli/src/ngtsc/transform/src/api.ts
Outdated
Comment thread
packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts
Outdated
atscott
force-pushed
the
inlineTemplateExternalCopy-language-service
branch
from
a18b8c1 to
7e3208c
Compare
May 6, 2026 20:36
crisbeto
approved these changes
May 6, 2026
Copy link
Copy Markdown
Contributor
Author
|
caretaker: failures were unrelated, passed on rerun (not sure why it doesn't update) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sorry, something went wrong.
mattrbeck
pushed a commit
that referenced
this pull request
May 7, 2026
…e typecheck blocks (#68454) This change updates the language service to generate TCBs for templates that would previously have required inlining. The new strategy is to copy the original source and then do inlining in the external TCB. This allows language features and type-checking in templates of non-exported classes (such as test components) or classes with local, non exported dependencies. PR Close #68454
Copy link
Copy Markdown
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.