FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(platform-server): throw on suspicious URLs and restrict protocol-relative URLs (19.2.x) by alan-agius4 · Pull Request #69044 · angular/angular · GitHub

fix(platform-server): throw on suspicious URLs and restrict protocol-relative URLs (19.2.x) - #69044

Merged
pkozlowski-opensource merged 2 commits into
angular:19.2.xfrom
alan-agius4:backport-68973-69018-19.2.x
Jun 2, 2026
Merged

fix(platform-server): throw on suspicious URLs and restrict protocol-relative URLs (19.2.x)#69044
pkozlowski-opensource merged 2 commits into
angular:19.2.xfrom
alan-agius4:backport-68973-69018-19.2.x

Conversation

Copy link
Copy Markdown
Contributor

…r URL parsing behavior

Extracts the regular expression for matching malformed absolute URLs to a module-scoped constant in url.ts.

Additionally, adds comprehensive inline documentation to clarify:
- The path normalization behavior of LEADING_SLASHES_REGEX which collapses consecutive slashes and backslashes.
- The rationale for using 'http://localhost' as the fallback base URL for virtual document initialization in server.ts.
angular-robot Bot added the area: server Issues related to server-side rendering label Jun 1, 2026
ngbot Bot added this to the Backlog milestone Jun 1, 2026
alan-agius4 requested review from JeanMeche and removed request for pkozlowski-opensource June 1, 2026 07:39
alan-agius4 removed the request for review from pkozlowski-opensource June 1, 2026 07:40
alan-agius4 added target: lts This PR is targeting a version currently in long-term support action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 1, 2026
alan-agius4 removed the request for review from JeanMeche June 1, 2026 17:02
alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

caretaker note: please ignore the mergability failure.

angular deleted a comment from ngbot Bot Jun 2, 2026
pkozlowski-opensource merged commit e2fb854 into angular:19.2.x Jun 2, 2026
35 of 38 checks passed

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

alan-agius4 deleted the backport-68973-69018-19.2.x branch June 2, 2026 11:09

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL