fix(router): fall back when serializing protocol-relative URLs - #70257
Open
SkyZeroZx wants to merge 1 commit into
Open
fix(router): fall back when serializing protocol-relative URLs#70257SkyZeroZx wants to merge 1 commit into
SkyZeroZx wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. The exception surfaced existing test data and mistaken command construction as a breaking change after angular#69874. Warn in development mode and serialize the tree as "/" instead. Keep the browser-facing URL root-relative without changing command or route-recognition semantics. The original fix had to be reverted after a regression surfaced in g3: angular#69874 (comment) This uses the less disruptive fallback proposed in the follow-up discussion: angular#69874 (comment) Fixes angular#69700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. The exception surfaced existing test data and mistaken command construction as a breaking change after #69874.
Warn in development mode and serialize the tree as "/" instead. Keep the browser-facing URL root-relative without changing command or route-recognition semantics.
The original fix had to be reverted after a regression surfaced in g3
See #69874 (comment)
This uses the less disruptive fallback proposed in #69874 (comment)
Fixes #69700