Repository navigation
fix(platform-server): reject protocol-relative paths in resolveUrl - #71077
Merged
atscott merged 1 commit intoSep 30, 2026
Merged
atscott merged 1 commit into
atscott merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Previously, resolveUrl only checked whether the raw URL string started with '//' before WHATWG URL resolution. When given an input such as '/.//evil.test', WHATWG dot-segment normalization popped the leading '/.', leaving a pathname starting with '//'. This corrupted ServerPlatformLocation and led to protocol-relative open redirects in SSR. Now, resolveUrl also verifies that the normalized URL pathname does not start with '//' when allowProtocolRelative is false. Fixes angular#71076
This was referenced Sep 30, 2026
JeanMeche
approved these changes
Sep 30, 2026
Copy link
Copy Markdown
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, resolveUrl only checked whether the raw URL string started with // before WHATWG URL resolution. When given an input such as /.//evil.test (or serialized from route shapes like /.;/(//evil.test)), WHATWG dot-segment normalization popped the leading /., leaving a pathname starting with //. This corrupted ServerPlatformLocation and led to protocol-relative open redirects in SSR.
Now, resolveUrl also verifies that the normalized URL pathname does not start with // when allowProtocolRelative is false.
Fixes #71076