Fix hydration cleanup let declarations - #71141
Open
sod wants to merge 1 commit into
Open
sod wants to merge 1 commit into
sod wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Contributor
|
CLA will be failing until you remove the Claude co-auth from the commits |
Sorry, something went wrong.
`cleanupLView` walks the LView slots and recurses into every value that looks like an LView or LContainer. Let declarations store arbitrary values in those slots, so an array of objects stored in a `@let` that is read from a nested view was treated as an LView, and `cleanupI18nHydrationData` wrote `i18nNodes` and `dehydratedIcuData` onto its 7th element. This silently mutated application data, or threw if the data was frozen. Let declarations are now skipped, the same way `annotateLView` already
sod
force-pushed
the
fix-hydration-cleanup-let-declarations
branch
from
85730c2 to
a1d16fd
Compare
October 2, 2026 15:54
Copy link
Copy Markdown
Contributor
Author
|
Squashed the commits and removed the claude opus 5.5 annotation. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #71138
fixes #59504
Apparently this was already fixed server side via #57816, but not guarded client side.
The added spec shows this error before the fix:
index 6 is the hydration slot in LView.