Repository navigation
fix(core): keep running sibling root effects after one throws - #71154
Open
erkamyaman wants to merge 1 commit into
Open
erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`ZoneAwareEffectScheduler.flushQueue` ran each scheduled effect with an unguarded call, so an effect that threw aborted the flush and left every effect queued after it dirty but unreached. Because `synchronizeOnce` clears the `RootEffects` dirty flag before flushing, nothing re-raised a flush for the stranded effects, and they stopped reacting to their dependencies until an unrelated effect happened to trigger another flush. Report the error to the application error handler and continue the loop, resolving the long-standing TODO in this file.
erkamyaman
force-pushed
the
fix-root-effect-sibling-starvation
branch
from
a9fbd69 to
26990af
Compare
October 4, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one root effect throws, the flush loop stops and every effect after it silently stops working, it never runs again until some other effect happens to trigger a new flush. There's even a // TODO: what happens if this throws an error? sitting on that exact line. This catches the error, reports it to the app error handler, and keeps going, so one broken effect no longer takes its siblings down with it. Scoped to the root effect scheduler.