fix(router): check abort signal state on subscribe - #71176
Draft
arturovt wants to merge 1 commit into
Draft
arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Prior to this commit, `abortSignalToObservable` checked `signal.aborted` when the observable was created, not when it was subscribed. canMatch and canLoad guards create their observables first and subscribe to them later, so a guard that starts a new navigation (e.g. calls `router.navigateByUrl()` and returns `false`) could abort the signal in between. Earlier guards then added the abort listener to an already aborted signal, never saw the abort and stayed subscribed until they settled on their own (or forever, if they never emit). There's no open issue for this, likely because people don't see router internals and might expect earlier guards to keep running as normal behavior. With this fix, the aborted state is checked on subscribe, so earlier guards are never subscribed once the navigation has been aborted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, abortSignalToObservable checked signal.aborted when the observable was created, not when it was subscribed. canMatch and canLoad guards create their observables first and subscribe to them later, so a guard that starts a new navigation (e.g. calls router.navigateByUrl() and returns false) could abort the signal in between. Earlier guards then added the abort listener to an already aborted signal, never saw the abort and stayed subscribed until they settled on their own (or forever, if they never emit). There's no open issue for this, likely because people don't see router internals and might expect earlier guards to keep running as normal behavior.
With this fix, the aborted state is checked on subscribe, so earlier guards are never subscribed once the navigation has been aborted.