FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(@angular-devkit/build-angular): fine grain settings for sourceMaps by alan-agius4 · Pull Request #13062 · angular/angular-cli · GitHub

/ angular-cli Public

feat(@angular-devkit/build-angular): fine grain settings for sourceMaps - #13062

Merged
vikerman merged 2 commits into
angular:masterfrom
alan-agius4:fine_grain_sourcemaps
Nov 30, 2018
ConversationCommits (2)ChecksFiles changed
Merged

feat(@angular-devkit/build-angular): fine grain settings for sourceMaps#13062
vikerman merged 2 commits into
angular:masterfrom
alan-agius4:fine_grain_sourcemaps

Conversation

alan-agius4 commented Nov 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normally used for error reporting tools.

Fixes #7527

alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 27, 2018
alan-agius4 removed the target: patch This PR is targeted for the next patch release label Nov 27, 2018
alan-agius4 removed the request for review from filipesilva November 27, 2018 12:56

alan-agius4 commented Nov 27, 2018

Copy link
Copy Markdown
Collaborator Author

Still need to add a couple of tests but this is the idea. @clydin, @hansl, @filipesilva

alan-agius4 requested review from clydin, filipesilva and hansl and removed request for clydin and hansl November 27, 2018 14:17
filipesilva approved these changes Nov 29, 2018
View reviewed changes

filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM overall. Really nice work and test coverage.

Historically, any change we make to sourcemaps breaks something though. It's just very hard to test the correctness of sourcemaps. After this comes in we should be especially aware on the issue tracker.

Comment thread packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts
Comment thread packages/angular/cli/lib/config/schema.json Outdated
},
"sourceMap": {
"type": "boolean",
"type": [

filipesilva Nov 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Schema bookkeeping is getting pretty annoying. We should find a way around this sometime.

alan-agius4 Nov 29, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, it’s pretty hard even just to add a new property. You have to add t in multiple places

ngbot Bot commented Nov 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Artifact Baseline Current Change
❕ cli/new-production/test-project/main.js 173.60KB 174.25KB +661 bytes

feat(@angular-devkit/build-angular): fine grain settings for sourceMaps
d64f2fe 
This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normaly used for error reporting tools.

Fixes #7527
angular deleted a comment from ngbot Bot Nov 30, 2018
alan-agius4 added the target: major This PR is targeted for the next major release label Nov 30, 2018
vikerman merged commit 8516d68 into angular:master Nov 30, 2018
alan-agius4 deleted the fine_grain_sourcemaps branch December 1, 2018 06:36
alan-agius4 mentioned this pull request Dec 4, 2018
Closed
alan-agius4 mentioned this pull request Jan 23, 2019
Closed
This was referenced Jan 30, 2019
Open
Closed
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 2, 2019
fix(@angular-devkit/build-angular): use sourcemap object in karma plugin
e362d7a 
Followup to angular#13062

Fix angular#13580
filipesilva mentioned this pull request Feb 2, 2019
Merged
vikerman pushed a commit that referenced this pull request Feb 6, 2019
fix(@angular-devkit/build-angular): use sourcemap object in karma plu…
e6f96fb 
…gin (#13584)

Followup to #13062

Fix #13580
vikerman pushed a commit that referenced this pull request Feb 6, 2019
fix(@angular-devkit/build-angular): use sourcemap object in karma plu…
acc31ba 
…gin (#13584)

Followup to #13062

Fix #13580

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

clydin clydin left review comments
+2 more reviewers
hansl hansl left review comments
filipesilva filipesilva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option for hidden-source-map to use with ng build --prod

6 participants

Back | FazBrowse Home | New Git URL