FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(@angular/cli): serialize configuration as a single argv token in run_target strategies by herdiyana256 · Pull Request #33657 · angular/angular-cli · GitHub

/ angular-cli Public

fix(@angular/cli): serialize configuration as a single argv token in run_target strategies #33657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Aug 7, 2026
Conversation 6 Commits 2 Checks 40 Files changed
Merged

fix(@angular/cli): serialize configuration as a single argv token in run_target strategies #33657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f66978
fix(@angular/cli): serialize configuration as a single argv token in …
herdiyana256 Jul 24, 2026
3a64247
fix(@angular/cli): apply prettier formatting to unit-test-strategy_sp…
herdiyana256 Aug 7, 2026
File filter

Filter by extension

Filter by extension .ts  (5) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion packages/angular/cli/src/commands/mcp/tools/run-target/build-target-strategy.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class BuildTargetStrategy implements TargetStrategy {
): Promise<RunTargetOutput> {
const args = ['build', input.projectName];
if (input.configuration) {
args.push('-c', input.configuration);
args.push(`--configuration=${input.configuration}`);
}

args.push(...serializeOptions(input.options));
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/cli/src/commands/mcp/tools/run-target/generic-target-strategy.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class GenericTargetStrategy implements TargetStrategy {
}

if (input.configuration) {
args.push('-c', input.configuration);
args.push(`--configuration=${input.configuration}`);
}

let options = input.options;
Expand Down
4 changes: 2 additions & 2 deletions packages/angular/cli/src/commands/mcp/tools/run-target/run-target_spec.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('Run Target Tool', () => {
mockContext.workspace.extensions['defaultProject'] = 'my-app';
await runTarget({ target: 'build', configuration: 'production' }, mockContext);
expect(mockHost.executeNgCommand).toHaveBeenCalledWith(
['build', 'my-app', '-c', 'production'],
['build', 'my-app', '--configuration=production'],
{
cwd: '/test',
},
Expand All @@ -53,7 +53,7 @@ describe('Run Target Tool', () => {
mockContext.workspace.extensions['defaultProject'] = 'my-app';
await runTarget({ target: 'storybook', configuration: 'docs' }, mockContext);
expect(mockHost.executeNgCommand).toHaveBeenCalledWith(
['run', 'my-app:storybook', '-c', 'docs'],
['run', 'my-app:storybook', '--configuration=docs'],
{ cwd: '/test' },
);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/cli/src/commands/mcp/tools/run-target/unit-test-strategy.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class UnitTestTargetStrategy implements TargetStrategy {
): Promise<RunTargetOutput> {
const args = ['test', input.projectName];
if (input.configuration) {
args.push('-c', input.configuration);
args.push(`--configuration=${input.configuration}`);
}

const builder = input.targetDefinition?.builder;
Expand Down
10 changes: 9 additions & 1 deletion packages/angular/cli/src/commands/mcp/tools/run-target/unit-test-strategy_spec.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,15 @@ describe('UnitTestTargetStrategy', () => {
);

expect(mockHost.executeNgCommand).toHaveBeenCalledWith(
['test', 'my-app', '-c', 'ci', '--browsers', 'ChromeHeadless', '--watch', 'false'],
[
'test',
'my-app',
'--configuration=ci',
'--browsers',
'ChromeHeadless',
'--watch',
'false',
],
{ cwd: '/test' },
);
});
Expand Down
Back | FazBrowse Home | New Git URL