FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(cb-a11y): add accessibility (a11y) cookbook by AlmeroSteyn · Pull Request #1625 · angular/angular.io · GitHub

This repository was archived by the owner on Dec 4, 2017. It is now read-only.
/ angular.io Public archive

docs(cb-a11y): add accessibility (a11y) cookbook - #1625

Open
AlmeroSteyn wants to merge 6 commits into
angular:masterfrom
IdeaBlade:cb-a11y-dt
ConversationCommits (6)ChecksFiles changed
Open

docs(cb-a11y): add accessibility (a11y) cookbook#1625
AlmeroSteyn wants to merge 6 commits into
angular:masterfrom
IdeaBlade:cb-a11y-dt

Conversation

AlmeroSteyn commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

READY FOR REVIEW

Current and up to date PR for the a11y cookbook.

Also contains copy-edits from @naomiblack from #1181 .

Both #1049 and #1181 are now outdated in terms of content and should be closed, but conserved for comments therein.

This was referenced Jun 8, 2016
Closed
Closed
Open
mattdistefano reviewed Jun 8, 2016
View reviewed changes
Comment thread public/docs/ts/latest/cookbook/a11y.jade Outdated
Similarly, we need to provide quick in-page links to help users who rely on assistive
technology to navigate our page.

These are called `skiplinks` and remain completely hidden until focused through `keyboard navigation`.

mattdistefano Jun 8, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm noting this here but it's more of a general question - are the code backticks appropriate for calling out technical terms or should some of these really be ems?

AlmeroSteyn Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These do provide a particular emphasis highlight that is used a lot inside the docs.

mattdistefano Jun 10, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Right, but typically the code backticks are for actual snippets of code or commands - variable names, hex values, CLI commands, that sort of thing. Whereas technical terms get the em treatment.

AlmeroSteyn Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed. However that is more an A2 doc wide discussion so will align this one to the styles of the other docs for now.

Foxandxss changed the title docs(cb-a11y): add accessibility (a11y) cookbook [Ready for review] docs(cb-a11y): add accessibility (a11y) cookbook Jun 9, 2016
AlmeroSteyn force-pushed the cb-a11y-dt branch 3 times, most recently from 99d1ced to 8b74462 Compare July 1, 2016 07:55
AlmeroSteyn force-pushed the cb-a11y-dt branch 2 times, most recently from f484de2 to 603a407 Compare July 18, 2016 14:28

chalin commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

@AlmeroSteyn - e2e tests are failing because the ts compiler is reporting errors. Can you investigate and fix the issues?

cc @naomiblack @wardbell

chalin commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

All: @AlmeroSteyn isn't currently available. As agreed discussed with @wardbell via slack: @Foxandxss or @filipesilva could you look into upgrading the code from use of ng beta/rc to 2.1.x?

googlebot commented Oct 26, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot commented Dec 8, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment

googlebot commented Dec 8, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

niceredfrog commented Dec 14, 2016

Copy link
Copy Markdown

I authored the most recent commit. I'm replying to confirm.

marcysutton commented Apr 7, 2017

Copy link
Copy Markdown

What do we need to do to get this up to date and merged?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: review CLA: no type: cookbook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL