| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
The publish job reads this literal at tag time. The sample's file: tarball dependency path and its README install example carry the same version, so they move together.
There was a problem hiding this comment.
LGTM, approving.
One non-blocking thing before you cut the tag: root package-lock.json still records 21.0.0-rc.0, in both the top-level version and packages[""].version. The v20 cut (c1c6af9) moved them together with package.json. CI will not catch it: npm ci exits 0 on a root-version-only mismatch, though it does exit 1 on a dependency mismatch, so the check is not dead. The cost is a stray diff in someone's unrelated PR later, since the next root npm install rewrites that field. Both behaviours checked against npm, not inferred. npm install --package-lock-only covers it.
sample/package-lock.json still names the rc.0 tarball, which makes npm ci in sample/ fail EUSAGE, but the README says to install the tarball by name and leave that lockfile uncommitted, so I read it as intended.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Checklist
Description
Bumps the root package.json version literal to 21.0.0-rc.1 ahead of the release tag. The publish workflow reads this literal to name the npm release.
The sample consumes the library as file:../angular-fire-<version>.tgz, so its package.json dependency path and the install example in its README are bumped to the same version in this change.