FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: bump version to 21.0.0-rc.1 by armando-navarro · Pull Request #3751 · angular/angularfire · GitHub

chore: bump version to 21.0.0-rc.1 - #3751

Open
armando-navarro wants to merge 1 commit into
angular:mainfrom
armando-navarro:rc1-version-bump
Open

chore: bump version to 21.0.0-rc.1#3751
armando-navarro wants to merge 1 commit into
angular:mainfrom
armando-navarro:rc1-version-bump

Conversation

Copy link
Copy Markdown
Collaborator

Checklist

  • Issue number for this PR: none, release mechanics for the 21.0.0-rc.1 cut
  • Docs included?: only the sample README's install example, which names the tarball version
  • Test units included?: no, version literals only
  • In a clean directory, yarn install, yarn test run successfully?: not applicable, no source changed

Description

Bumps the root package.json version literal to 21.0.0-rc.1 ahead of the release tag. The publish workflow reads this literal to name the npm release.

The sample consumes the library as file:../angular-fire-<version>.tgz, so its package.json dependency path and the install example in its README are bumped to the same version in this change.

The publish job reads this literal at tag time. The sample's file:
tarball dependency path and its README install example carry the
same version, so they move together.
armando-navarro added bump: patch comp: build/pipeline Build, bundling, packaging, release pipeline. type: chore Maintenance with no user-facing behavior change. labels Aug 21, 2026

tyler-reitz left a comment
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, approving.

One non-blocking thing before you cut the tag: root package-lock.json still records 21.0.0-rc.0, in both the top-level version and packages[""].version. The v20 cut (c1c6af9) moved them together with package.json. CI will not catch it: npm ci exits 0 on a root-version-only mismatch, though it does exit 1 on a dependency mismatch, so the check is not dead. The cost is a stray diff in someone's unrelated PR later, since the next root npm install rewrites that field. Both behaviours checked against npm, not inferred. npm install --package-lock-only covers it.

sample/package-lock.json still names the rc.0 tarball, which makes npm ci in sample/ fail EUSAGE, but the README says to install the tarball by name and leave that lockfile uncommitted, so I read it as intended.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump: patch comp: build/pipeline Build, bundling, packaging, release pipeline. type: chore Maintenance with no user-facing behavior change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL