fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor - #23735
Merged
amysorto merged 1 commit intoNov 9, 2021
Conversation
trik
force-pushed
the
connected-overlay-position-change-decorator
branch
from
cfaee5d to
9cac963
Compare
October 12, 2021 11:20
crisbeto
reviewed
Oct 12, 2021
crisbeto
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I don't think that this is the correct fix. We should remove the Optional from the constructor instead.
Sorry, something went wrong.
trik
force-pushed
the
connected-overlay-position-change-decorator
branch
from
9cac963 to
447b956
Compare
October 12, 2021 16:30
trik
force-pushed
the
connected-overlay-position-change-decorator
branch
from
447b956 to
6342f1a
Compare
October 12, 2021 16:32
crisbeto
approved these changes
Oct 13, 2021
crisbeto
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
trik
force-pushed
the
connected-overlay-position-change-decorator
branch
2 times, most recently
from
bf5b03d to
b5ad302
Compare
October 21, 2021 09:51
…onChange constructor
trik
force-pushed
the
connected-overlay-position-change-decorator
branch
from
b5ad302 to
02240b9
Compare
October 21, 2021 09:57
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cdk/overlay): remove Optional decorator in ConnectedOverlayPositionChange constructor