fix(material/chips): add selected indication in high contrast mode - #23828
Merged
amysorto merged 1 commit intoNov 9, 2021
Merged
fix(material/chips): add selected indication in high contrast mode#23828amysorto merged 1 commit into
amysorto merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Currently the single-selection chip shows that it's selected by changing its background color, but that doesn't work in high contrast mode. These changes add a thicker outline when the chip is selected.
crisbeto
commented
Oct 25, 2021
Comment thread
src/material-experimental/mdc-chips/chip-option.ts
| '[class.mat-mdc-chip-with-avatar]': 'leadingIcon', | ||
| '[class.mat-mdc-chip-with-trailing-icon]': 'trailingIcon || removeIcon', | ||
| '[class.mat-mdc-chip-selected]': 'selected', | ||
| '[class.mat-mdc-chip-multiple]': '_chipListMultiple', |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I would've rather renamed the mat-mdc-chip-selected since there are no usages of it in our codebase, but there are some in g3.
Sorry, something went wrong.
jelbourn
approved these changes
Nov 1, 2021
jelbourn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mmalerba
approved these changes
Nov 2, 2021
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the single-selection chip shows that it's selected by changing its background color, but that doesn't work in high contrast mode. These changes add a thicker outline when the chip is selected.