build: do not accidentally cache undesired files in github action - #23875
Merged
amysorto merged 1 commit intoNov 4, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This commit fixes that the Github actions currently may cache undesired files. e.g. when Bazel runs the `dist/` folder is populated and symlinked with the execroot, where another clone of the `node_modules` would be cached accidentally then. We use an explicit path instead of a pattern as it has been recommended by the Github action documentation. Additionally, we fix that the dev-app building on RBE occurs with 2 concurrent jobs due to the host containers only having 2 cores. We can run more jobs in the RBE containers.
devversion
force-pushed
the
build/improvements-dev-app-build
branch
from
53908fc to
ae8fbbc
Compare
November 2, 2021 21:37
Copy link
Copy Markdown
|
Deployed dev-app to: https://ng-comp-dev--pr-23875-ae8fbbcfc74c17cd42c8bb4c4f85332d-yw6byxit.web.app |
Sorry, something went wrong.
devversion
marked this pull request as ready for review
November 2, 2021 21:45
josephperrott
approved these changes
Nov 2, 2021
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
amysorto
pushed a commit
that referenced
this pull request
Nov 4, 2021
…3875) This commit fixes that the Github actions currently may cache undesired files. e.g. when Bazel runs the `dist/` folder is populated and symlinked with the execroot, where another clone of the `node_modules` would be cached accidentally then. We use an explicit path instead of a pattern as it has been recommended by the Github action documentation. Additionally, we fix that the dev-app building on RBE occurs with 2 concurrent jobs due to the host containers only having 2 cores. We can run more jobs in the RBE containers. (cherry picked from commit acd5ee1)
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes that the Github actions currently may cache undesired
files. e.g. when Bazel runs the dist/ folder is populated and
symlinked with the execroot, where another clone of the node_modules
would be cached accidentally then. We use an explicit path instead of a
pattern as it has been recommended by the Github action documentation.
Additionally, we fix that the dev-app building on RBE occurs with 2
concurrent jobs due to the host containers only having 2 cores. We can
run more jobs in the RBE containers.