refactor(multiple): clean up host decorator workarounds - #23879
Merged
amysorto merged 1 commit intoNov 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
We had some workarounds with `HostListener` and `HostBinding` which go against our conventions. They were used to support ViewEngine, but they are no longer necessary.
crisbeto
force-pushed
the
host-decorator-cleanup
branch
from
e75d94b to
e274004
Compare
November 3, 2021 07:54
crisbeto
marked this pull request as ready for review
November 3, 2021 08:06
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
November 3, 2021 08:06
devversion
approved these changes
Nov 3, 2021
jelbourn
approved these changes
Nov 3, 2021
jelbourn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LEGTM
Sorry, something went wrong.
amysorto
pushed a commit
that referenced
this pull request
Nov 8, 2021
We had some workarounds with `HostListener` and `HostBinding` which go against our conventions. They were used to support ViewEngine, but they are no longer necessary. (cherry picked from commit 5fb821f)
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some workarounds with HostListener and HostBinding which go against our conventions. They were used to support ViewEngine, but they are no longer necessary.