build: remove unused code from legacy tooling and remove view-engine leftovers - #23899
Merged
amysorto merged 2 commits intoNov 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…eftovers Removes unused code from legacy tooling and View Engine compilation within Bazel. Also the clang-format file is removed given that we run prettier in the whole repository now.
devversion
force-pushed
the
build/remove-unused-code
branch
from
0a9ebba to
087569e
Compare
November 4, 2021 17:00
josephperrott
approved these changes
Nov 4, 2021
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
crisbeto
approved these changes
Nov 4, 2021
crisbeto
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
…ngine leftovers ds
amysorto
pushed a commit
that referenced
this pull request
Nov 5, 2021
…leftovers (#23899) * build: remove unused code from legacy tooling and remove viewengine leftovers Removes unused code from legacy tooling and View Engine compilation within Bazel. Also the clang-format file is removed given that we run prettier in the whole repository now. * fixup! build: remove unused code from legacy tooling and remove viewengine leftovers ds (cherry picked from commit be9abca)
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused code from legacy tooling and View Engine compilation
within Bazel.
Also the clang-format file is removed given that we run prettier
in the whole repository now.