FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: fix examples not recognizing webcontainer stackblitz instances by devversion · Pull Request #23901 · angular/components · GitHub

/ components Public

refactor: fix examples not recognizing webcontainer stackblitz instances - #23901

Merged
amysorto merged 1 commit into
angular:masterfrom
devversion:update-sidenav-stackblitz-filter-regex
Nov 4, 2021
ConversationCommits (1)ChecksFiles changed
Merged

refactor: fix examples not recognizing webcontainer stackblitz instances#23901
amysorto merged 1 commit into
angular:masterfrom
devversion:update-sidenav-stackblitz-filter-regex

Conversation

devversion commented Nov 4, 2021

Copy link
Copy Markdown
Member

Fixes that examples do not properly recognize webcontainer Stackblitz
instances. This causes some sidenav examples to not even work within
Stackblitz as a message Please open on Stackblitz is displayed.

Fixes #23895.

refactor: fix examples not recognizing webcontainer stackblitz instances
ecf1f0a 
Fixes that examples do not properly recognize webcontainer Stackblitz
instances. This causes some sidenav examples to not even work within
Stackblitz as a message `Please open on Stackblitz` is displayed.

Fixes angular#23895.
devversion added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Nov 4, 2021
google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2021

devversion commented Nov 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

In the future, we could technically embed Stackblitz projects for these examples, so that users would not need to go to Stackblitz at all.. Not exactly sure about the problem sidenav examples though..

devversion commented Nov 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Just a note: From some brief experiments, it looks like we could serve these examples directly in the docs by forming a new containing block (i.e. by using a transform: translate3d(0, 0, 0)).. Might be worth looking into that in the future.

jelbourn approved these changes Nov 4, 2021
View reviewed changes

jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2021
amysorto merged commit e7a3f68 into angular:master Nov 4, 2021
amysorto pushed a commit that referenced this pull request Nov 4, 2021
refactor: fix examples not recognizing webcontainer stackblitz instan…
ca1e29e 
…ces (#23901)

Fixes that examples do not properly recognize webcontainer Stackblitz
instances. This causes some sidenav examples to not even work within
Stackblitz as a message `Please open on Stackblitz` is displayed.

Fixes #23895.

(cherry picked from commit e7a3f68)

angular-automatic-lock-bot Bot commented Dec 5, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

crisbeto Awaiting requested review from crisbeto
andrewseguin Awaiting requested review from andrewseguin
1 more reviewer
jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(stackblitz samples demo): stackblitz URL invalid in regex, unable to view result

3 participants

Back | FazBrowse Home | New Git URL