build: update karma to v6.3.8 which contains sourcemap generated-code fix - #23922
Merged
amysorto merged 1 commit intoNov 9, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… fix Updates to Karma v6.3.8 which contains a sourcemap fix we landed upstream. Previous versions of Karma printed/polluted the log output when an error is thrown due to generated-code being part of stack traces (due to ESBuild downleveling). More details here: https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c. karma-runner/karma@4f23b14
devversion
marked this pull request as ready for review
November 8, 2021 15:28
crisbeto
approved these changes
Nov 8, 2021
crisbeto
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
josephperrott
approved these changes
Nov 8, 2021
josephperrott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
amysorto
pushed a commit
that referenced
this pull request
Nov 9, 2021
… fix (#23922) Updates to Karma v6.3.8 which contains a sourcemap fix we landed upstream. Previous versions of Karma printed/polluted the log output when an error is thrown due to generated-code being part of stack traces (due to ESBuild downleveling). More details here: https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c. karma-runner/karma@4f23b14 (cherry picked from commit f69cf6c)
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Karma v6.3.8 which contains a sourcemap fix we landed
upstream. Previous versions of Karma printed/polluted the log output
when an error is thrown due to generated-code being part of stack
traces (due to ESBuild downleveling).
More details here:
https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c.
karma-runner/karma@4f23b14
Example stack trace in a test which uses async/await (which is downleveled)
