FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: use npm instead of yarn by viceice · Pull Request #471 · angular-split/angular-split · GitHub

/ angular-split Public

ci: use npm instead of yarn - #471

Merged
Jefiozie merged 2 commits into
angular-split:mainfrom
viceice:ci/use-npm
Nov 23, 2024
ConversationCommits (2)ChecksFiles changed
Merged

ci: use npm instead of yarn#471
Jefiozie merged 2 commits into
angular-split:mainfrom
viceice:ci/use-npm

Conversation

viceice commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

viceice commented Nov 20, 2024

Copy link
Copy Markdown
Contributor Author

it seems we need to relax peer dependencies 😔

SanderElias approved these changes Nov 21, 2024
View reviewed changes

SanderElias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks for the PR!

@Jefiozie If everything checks out, this is one less "3rth party".
Assuming there is no issue with the peerdeps?

SanderElias commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

@viceice @Jefiozie
The problem is that the package lock isn't generated correctly. Because of that, npm ci errors out. Not sure how/when that happened.

viceice commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

@SanderElias @Jefiozie I fixed the peer dependency issue via upgrading ngx-bootstrap1

Footnotes

  1. https://github.com/valor-software/ngx-bootstrap?tab=readme-ov-file#compatibility ↩

viceice commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

ngx-bootstrap is only used for tests, not a dep of the published package

Jefiozie merged commit 4f5b26c into angular-split:main Nov 23, 2024
viceice deleted the ci/use-npm branch November 23, 2024 09:09

Jefiozie commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

@all-contributors please add @viceice for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

allcontributors Bot mentioned this pull request Feb 2, 2025
Merged

allcontributors Bot commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

@Jefiozie

I've put up a pull request to add @viceice! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

SanderElias SanderElias approved these changes
Jefiozie Awaiting requested review from Jefiozie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL