fix: gutter content child without descendants - #518
Merged
Jefiozie merged 1 commit intoDec 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@Jefiozie @SanderElias what about this PR? |
Sorry, something went wrong.
SanderElias
approved these changes
Oct 30, 2025
SanderElias
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM.
Seeking deeper into the tree can only cause trouble
Sorry, something went wrong.
Harpush
force-pushed
the
gutter-content-child-without-descendants
branch
from
3959485 to
45e7cec
Compare
November 7, 2025 22:32
Copy link
Copy Markdown
Collaborator
Author
|
@SanderElias I rebased so ready for merge |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
@SanderElias @Jefiozie can we merge this? |
Sorry, something went wrong.
Jefiozie
approved these changes
Dec 26, 2025
Copy link
Copy Markdown
Contributor
|
Merged in the new year I will do a new release |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contentChild default behavior is to match descendants. For the gutter it means in nested splits the top split would get the same gutter defined in the inner split which I think is unexpected.
@SanderElias @Jefiozie Do you see any reason we might want descendants matching for the gutter directive?
Closes #517