This repository was archived by the owner on May 29, 2019. It is now read-only.
Repository navigation
fix(tooltip)change to make tooltip work when document contains multile body tags - #6598
Open
sshelake25 wants to merge 1 commit into
Open
sshelake25 wants to merge 1 commit into
sshelake25 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue raised: #6597
change when page contains multiple body tags inside it. uib tooltip does not works when append-to-body option set to true.
Previously when it finds multiple body tag, it is appending tooltip to wrong body tag hence not able to see it, also not removing appended tooltip element from DOM.
After applying fix it will always takes documents body tag instead of SVG element body tag.
BREAKING CHANGE: When page contains multiple body tag of SVG foreignObject tooltip does not work.