This repository was archived by the owner on May 29, 2019. It is now read-only.
Repository navigation
Properly position "uib-dropdown-menu" when it has class "dropdown-menu-right" and the parent element have hidden scrollbar - #6601
Open
Stalinko wants to merge 2 commits into
Open
Stalinko wants to merge 2 commits into
Stalinko wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…er the parent element has a visible scrollbar
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dropdown-menu is positioned relatively to the right it takes into account the right scrollbar width. It detects scrollbar by checking whether content height is bigger than clientHeight but sometimes scrollbar can be absent even when content doesn't fit the element visible area when "overflow = hidden".
In this pull request I'm adding proper check for this case.