FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

angular-ui-map doesnt play well with angular-ui-router. by SayreBlades · Pull Request #35 · angular-ui/ui-map · GitHub

This repository was archived by the owner on May 25, 2019. It is now read-only.
/ ui-map Public archive

angular-ui-map doesnt play well with angular-ui-router. - #35

Open
SayreBlades wants to merge 3 commits into
angular-ui:masterfrom
SayreBlades:angular-ui-router-fix
Open

angular-ui-map doesnt play well with angular-ui-router. #35
SayreBlades wants to merge 3 commits into
angular-ui:masterfrom
SayreBlades:angular-ui-router-fix

Conversation

Copy link
Copy Markdown

This change enables delayed construction of the google map component until the page has been loaded.

delays constrution of the google map until the page has been loaded.

Copy link
Copy Markdown
Contributor

This looks like a very specific and inflexible solution to a very general problem. What if UI Router and UI Map are combined with another module that controls template rendering (let's say, a tab directive)? Now you have to listen for two events. What if they don't agree about whether the map should be rendered? What if the order of events is nondeterministic?

👎 from me. A logical approach would use a $watch() to check that the container element is visible and has bounds and an offset.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL