| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
I didn't see a reason to keep the prefix as the original DOM elements are not used for anything else
|
I use original DOM events, because I need to to do a hack outside of $apply. Will this change break them? |
Sorry, something went wrong.
|
I'm a little confused, can you paste a snippet? What this does is before, things like clickclose events (from Google Maps API) would actually be routed to ui-event as map-clickclose to avoid accidentally triggering normal events on the relevant DOM element. I'm essentially dropping the prefix because I don't think the relevant DOM elements are used for anything other than giving you a handle to the map objects, and it only serves to make usage more complicated/confusing. |
Sorry, something went wrong.
|
Will I still be able to bind directly like in the snippet below? google.maps.event.addListener(scope.googleMap, 'bounds_changed', onBoundsChanged) # onBoundsChanged called outside $apply # and trigger google.maps.event.trigger(scope.googleMap, 'resize') |
Sorry, something went wrong.
|
Yes that will be completely unaffected. This only effects people who bind
|
Sorry, something went wrong.
|
OK, great! Thanks, sorry for not getting it :) |
Sorry, something went wrong.
There was a problem hiding this comment.
event will be undefined if methods like setCenter are called on an invisible map. if (!event) return?
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
I didn't see a reason to keep the prefix as the original DOM elements
are not used for anything else
This is a Pull Request because it's a destructive change. If anyone disagrees please make your voice known.