feat(tui): add session delete command with confirmation dialog - #11684
feat(tui): add session delete command with confirmation dialog#11684frouo wants to merge 7 commits into
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on the search results, I found one potentially related PR: PR #6732 - feat: add delete session button to session header This PR is related because it also addresses session deletion functionality. However, PR #6732 adds a delete button to the session header UI, while the current PR #11684 adds a /delete command with a confirmation dialog. These are different approaches to the same feature (deleting a session), so they may be addressing the same underlying issue (#8677) but with different implementations. You should verify if one of these PRs has already been merged or if they should be consolidated into a single approach. |
Sorry, something went wrong.
Without preventDefault or stopPropagation, the return key event continues propagating after the dialog closes. When navigating to a new screen with a prompt (e.g., after deleting a session via /delete command), the stale event inserts an unwanted newline, causing the cursor to start on line 2 instead of line 1. Tested independently: both preventDefault() and stopPropagation() fix the issue on their own. Claude Sonnet 4.5 recommands adding both as the safest approach and aligns with the existing pattern used in DialogSelect.
…rrent-session-#8677
|
Hello, would it be possible to merge this one please? |
Sorry, something went wrong.
…rrent-session-#8677
|
Hello @thdxr , do you think this this PR could be merged? Thank you |
Sorry, something went wrong.
…rrent-session-#8677
There was a problem hiding this comment.
As maintainers are busy, I will do basic review.
Please exclude files not related to the feature (whitespace, spelling and documentation fixes).
I suggest "ctrl-x (leader), d" to keep uniform bindings. Also ctrl-d now closes the app, better keep it that way.
Sorry, something went wrong.
What does this PR do?
Added a /delete command to delete the current session
Closes #8677
Demo video : #8677 (comment).
Note: The 3rd commit fixes a routing bug shown at the end of the demo video where an extra newline appeared when returning to the home screen after deletion.
How did you verify your code works?
I tested it by running bun dev.