fix(nix): include .github/TEAM_MEMBERS in fileset - #15401
Conversation
Sorry, something went wrong.
After anomalyco#15369, the build script reads `.github/TEAM_MEMBERS` at build time, but this file was not included in the Nix source fileset. Also add the file to nix-hashes.yml paths trigger so hash regeneration is triggered when the file changes. Fixes anomalyco#15400
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR fixes a reported Nix build failure (issue #15400) by including .github/TEAM_MEMBERS in the nix/node_modules.nix fileset and adding a path trigger for hash regeneration in the CI workflow.
Changes:
- Add ../.github/TEAM_MEMBERS to the fileset in nix/node_modules.nix
- Add .github/TEAM_MEMBERS as a path trigger in .github/workflows/nix-hashes.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nix/node_modules.nix | Adds .github/TEAM_MEMBERS to the source fileset so it is available during the Nix build |
| .github/workflows/nix-hashes.yml | Triggers hash regeneration when .github/TEAM_MEMBERS changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
TEAM_MEMBERS is not read during bun install phase, so it doesn't affect node_modules hash. Only the fileset change is needed.
|
@rekram1-node: if you first step upon that PR, merge #15648 instead that contains both nix package build fixes. |
Sorry, something went wrong.
Issue for this PR
Closes #15400
Type of change
What does this PR do?
After #15369, packages/script/src/index.ts reads .github/TEAM_MEMBERS at build time. This file wasn't included in nix/node_modules.nix fileset, causing ENOENT during Nix builds.
This PR adds ../.github/TEAM_MEMBERS to the fileset in nix/node_modules.nix.
How did you verify your code works?
nix build now proceeds past the TEAM_MEMBERS file read.
Screenshots / recordings
N/A - not a UI change
Checklist