FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(www): stabilize locale routing by akronb · Pull Request #16402 · anomalyco/opencode · GitHub

/ opencode Public

refactor(www): stabilize locale routing - #16402

Closed
akronb wants to merge 10 commits into
anomalyco:devfrom
akronb:fix-docs-locale
ConversationCommits (10)ChecksFiles changed
Closed

refactor(www): stabilize locale routing#16402
akronb wants to merge 10 commits into
anomalyco:devfrom
akronb:fix-docs-locale

Conversation

akronb commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #17665
Closes #16278
Closes #15984
Closes #15904
Closes #15194
Closes #14997
Closes #14409

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes the docs locale architecture introduced in #12508, which made routing dependent on ambient locale state and treated English as a special-case root path. Rather than patching symptoms (#13109, #13608), this addresses the root cause by making docs URLs path-authoritative and promoting English to an explicit en locale.

Key changes:

  • Switch Starlight config from defaultLocale: "root" to defaultLocale: "en"
  • Move English docs content into packages/web/src/content/docs/en/
  • Add shared docs locale helpers in packages/web/src/lib/docs-locale.ts
  • Update web middleware to redirect /docs and /docs/<slug> to their locale-prefixed equivalents, normalize legacy /docs/... paths to /docs/en/..., and set the oc_locale cookie only on redirects from bare docs entry paths
  • Centralize console docs proxy logic in packages/console/app/src/lib/docs.ts
  • Update docs sync/update workflows and agent prompts to reference the new English docs path

How did you verify your code works?

Added targeted regression tests across both packages:

  • Console: docs locale resolution in packages/console/app/test/language.test.ts
  • Web: docs redirects and cookie handling (English, non-English, and unknown locale-like paths) in packages/web/test/middleware.test.ts

Ran bun test, bun run astro check, and bun run typecheck in the affected packages, and confirmed that the docs sync workflow and translator agent now point at the new English docs source path.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

github-actions Bot mentioned this pull request Mar 7, 2026
Closed

akronb commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@adamdotdevin could you take a look?

github-actions Bot mentioned this pull request Mar 15, 2026
Closed
6 tasks

B2F commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR is targeting the resolution of at least 7 threads + #22415
@R44VC0RP

B2F mentioned this pull request Apr 27, 2026
Closed
Merge branch 'dev' into fix-docs-locale
c6e963c 
# Conflicts:
#	.github/workflows/docs-locale-sync.yml
#	.opencode/agent/docs.md
#	.opencode/agent/translator.md
#	packages/console/app/src/lib/language.ts
#	packages/web/src/content/docs/en/enterprise.mdx
#	packages/web/src/content/docs/en/modes.mdx
akronb force-pushed the fix-docs-locale branch from 580c6c6 to c6e963c Compare June 29, 2026 18:54

akronb commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

already fixed (#32551)

akronb closed this Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Back | FazBrowse Home | New Git URL