fix(opencode): sanitize history and gate options on target model switch - #16630
fix(opencode): sanitize history and gate options on target model switch#16630tobwen wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR that overlaps with the current PR: Related PR:
This PR (16630) explicitly mentions in its description that it "overlaps with #11572" as part of covering the same bug class. The current PR appears to be a more comprehensive fix that also addresses issues #16154, #11571, and #14783 in a unified way, likely superseding or extending the earlier approach in PR #11572. |
Sorry, something went wrong.
When a session switches to a different target model, it now sanitizes history and request options against that target model's capabilities. - Strips incompatible reasoning/tool history for targets that do not support those features - Preserves field-based reasoning metadata for interleaved targets - Filters unsupported reasoning/thinking options - Gates tool resolution plus toolChoice on target model toolcall Added regression tests for GPT reasoning history -> non-reasoning OpenAI-compatible Mistral.
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Sorry, something went wrong.
Issue for this PR
Fixes #16154
Also covers the same bug class as closed issue #11571 and overlaps with #11572 and #14783.
Type of change
What does this PR do?
When a session switches to a different target model, it now sanitizes history and request options against that target model's capabilities.
Added regression tests for GPT reasoning history -> non-reasoning OpenAI-compatible Mistral.
How did you verify your code works?
Ran from packages/opencode:
Screenshots / recordings
Not a UI change.
Checklist