FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(app): QOL: don't sign commits during e2e tests by benjamincburns · Pull Request #18296 · anomalyco/opencode · GitHub

chore(app): QOL: don't sign commits during e2e tests - #18296

Closed
benjamincburns wants to merge 1 commit into
anomalyco:devfrom
benjamincburns:qol/dont_sign_commits_during_e2e_tests
Closed

chore(app): QOL: don't sign commits during e2e tests#18296
benjamincburns wants to merge 1 commit into
anomalyco:devfrom
benjamincburns:qol/dont_sign_commits_during_e2e_tests

Conversation

Copy link
Copy Markdown

Issue for this PR

Closes #18295

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement (QOL for local dev/test)
  • Documentation

What does this PR do?

When I try to run e2e tests locally I get spammed by pinentry-touchid because I have git configured globally to sign commits. This simple one-line change disables commit signing for repositories used during e2e tests, preventing pinentry-touchid from ruining my day.

How did you verify your code works?

I ran e2e tests with the change in place.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

When I try to run e2e tests locally I get spammed by `pinentry-touchid` because
I have git configured globally to sign commits. This simple one-line change
disables commit signing for repositories used during e2e tests, preventing
`pinentry-touchid` from ruining my day.

Copy link
Copy Markdown
Collaborator

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Copy link
Copy Markdown
Author

This was ready to merge, no other work was necessary AFAIK

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QOL - running e2e tests locally spams me with pinentry-touchid signing requests

2 participants


Back | FazBrowse Home | New Git URL