FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(permission): wire permission.ask plugin hook by yohi · Pull Request #30509 · anomalyco/opencode · GitHub

/ opencode Public

feat(permission): wire permission.ask plugin hook - #30509

Open
yohi wants to merge 10 commits into
anomalyco:devfrom
yohi:feat/permission-ask-hook
ConversationCommits (10)ChecksFiles changed
Open

feat(permission): wire permission.ask plugin hook#30509
yohi wants to merge 10 commits into
anomalyco:devfrom
yohi:feat/permission-ask-hook

Conversation

yohi commented Jun 3, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #7006
Closes #22311

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Properly wires the permission.ask plugin hook by adding Plugin.trigger right before the prompt. This allows plugins to
intercept and return allow or deny. It passes a shallow copy of the request info to prevent accidental mutation by plugins,
and uses Effect.catchCause so plugin defects don't crash the core flow.

How did you verify your code works?

Injected a mocked PluginLayer into next.test.ts and added specific test cases for plugin allow, deny, and exception
paths. All 82 tests pass successfully.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

yohi added 3 commits June 3, 2026 14:17
feat(permission): wire permission.ask plugin hook
a60ce94 
Closes anomalyco#7006
Closes anomalyco#22311
fix: address review comments for feat/permission-ask-hook
d7203b8 
- Handle plugin errors in permission.ask hook and fallback to ask
- Add test cases for allow, deny, and error paths in plugins
- Add documentation for empty ruleset on plugin denial
fix(permission): prevent plugin mutation of permission request data b…
3b35211 
…y passing a copy

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

I found one potentially related PR:

Related PR:

The other search result (#12520) is unrelated to permissions.

Since #19453 exists, you may want to check if it was closed/abandoned and whether your PR supersedes it or builds upon it.

yohi commented Jun 3, 2026

Copy link
Copy Markdown
Author

The following comment was made by an LLM, it may be inaccurate:

I found one potentially related PR:

Related PR:

The other search result (#12520) is unrelated to permissions.

Since #19453 exists, you may want to check if it was closed/abandoned and whether your PR supersedes it or builds upon it.

Thanks for the pointer! I reviewed #19453.

While both PRs aim to wire the permission.ask hook, this new PR (#30509) supersedes it by addressing critical safety and
reliability concerns:

    1. Safety (Mutation Prevention): This PR passes a shallow copy of the request info to the plugins, preventing malicious or
      buggy plugins from mutating the pending request state.
    1. Reliability (Error Handling): This PR wraps Plugin.trigger with Effect.catchCause. If a plugin throws an exception or
      defect, it gracefully falls back to the standard user prompt instead of crashing the agent's core execution flow.
    1. Testing: This PR includes comprehensive test coverage for allow, deny, and error paths using a mocked PluginLayer.

I believe this makes it a safer and more complete implementation. Please let me know what you think!

yohi marked this pull request as ready for review June 3, 2026 05:56

rafaelspecta commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Why is this not merged yet? Who needs to approve this?

DKotsyuba commented Jun 24, 2026

Copy link
Copy Markdown

Please accept this pull request as soon as possible!

yohi mentioned this pull request Jul 11, 2026
Merged
This was referenced Jul 29, 2026
Closed
Open
github-actions Bot mentioned this pull request Aug 14, 2026
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

permission.ask plugin hook is defined but not triggered [FEATURE]: Wire the permission.ask plugin hook

3 participants

Back | FazBrowse Home | New Git URL