FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(opencode): sanitize OpenAI schema patterns by kunickiaj · Pull Request #30552 · anomalyco/opencode · GitHub

/ opencode Public

fix(opencode): sanitize OpenAI schema patterns - #30552

Closed
kunickiaj wants to merge 1 commit into
anomalyco:devfrom
kunickiaj:ajk--fix_opencode_sanitize_openai_schema_patterns
ConversationCommits (1)ChecksFiles changed
Closed

fix(opencode): sanitize OpenAI schema patterns#30552
kunickiaj wants to merge 1 commit into
anomalyco:devfrom
kunickiaj:ajk--fix_opencode_sanitize_openai_schema_patterns

Conversation

kunickiaj commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #30553

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

OpenAI rejects some tool parameter schemas containing regex pattern constraints, which can surface as a generic server_error during tool calls. This strips those pattern constraints only for @ai-sdk/openai models while preserving non-OpenAI schemas and legitimate properties named pattern.

Repro / context

With Backstage MCP enabled and an OpenAI-backed GPT-5.5 model, requests could fail before tool execution with a generic server_error / response.failed.

The trigger was MCP tool schemas containing many JSON Schema pattern regex constraints, such as Backstage entity refs and catalog filters. OpenAI's tool schema validator rejects that shape in practice, while Anthropic/Bedrock accept it.

Validated locally against the real opencode config with Backstage enabled:

  • before: GPT-5.5 + Backstage MCP crashed with server_error / response.failed
  • after: GPT-5.5 successfully routed to backstage_auth_who-am-i
  • the resulting NotAllowedError was expected Backstage auth behavior, which confirmed the model request/tool-routing path no longer crashed
  • we also reran a live session after the patch and the original issue no longer reproduced

How did you verify your code works?

  • bun test test/provider/transform.test.ts
  • bun typecheck
  • pre-push bun turbo typecheck
  • live GPT-5.5 session with Backstage MCP enabled completed tool routing without the previous crash

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jun 3, 2026

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jun 3, 2026

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

kunickiaj mentioned this pull request Jun 12, 2026
Closed
kunickiaj force-pushed the ajk--fix_opencode_sanitize_openai_schema_patterns branch from 6c2afa7 to dc3984c Compare June 14, 2026 13:37
github-actions Bot mentioned this pull request Jun 16, 2026
Merged
6 tasks

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

github-actions Bot closed this Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GPT-5.5 tool calls fail with Backstage MCP pattern schemas

1 participant

Back | FazBrowse Home | New Git URL