fix(tui): /sessions search shows all sessions while loading results - #31205
fix(tui): /sessions search shows all sessions while loading results#31205mdshzb04 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Sorry, something went wrong.
When a user types in the /sessions search box, createResource starts fetching filtered results. While loading, searchResults() is undefined, and the fallback to sync.data.session caused ALL sessions to be shown instead of an empty/loading state. Now, when a search query is active, we return an empty array while loading instead of falling back to the full session list. Fixes anomalyco#31182
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Sorry, something went wrong.
Issue for this PR
Closes #31182
Type of change
What does this PR do?
/sessions search showed all sessions while waiting for API results because searchResults() ?? sync.data.session fell back to the full list when searchResults() was undefined.
Only fall back to sync.data.session when no search query is active. During an active search, return [] while loading so the UI shows "No results found" instead of everything.
Note: Rebased onto latest dev. Upstream removed packages/tui/src/feature-plugins/session/dialog.tsx in #31524, so this fix now only touches packages/tui/src/component/dialog-session-list.tsx.
How did you verify your code works?
bun typecheck passes in packages/tui. The /sessions search now correctly filters results while loading.
Screenshots / recordings
N/A — TUI change, no visual regression.
Checklist