fix(session): avoid full history hydration after compaction - #31638
Open
ualtinok wants to merge 1 commit into
Open
fix(session): avoid full history hydration after compaction#31638ualtinok wants to merge 1 commit into
ualtinok wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ualtinok
force-pushed
the
fix/filter-compacted-history-load
branch
2 times, most recently
from
2eaeac0 to
dadf38e
Compare
June 14, 2026 05:04
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Jun 25, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Jun 25, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Jun 30, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
iceteaSA
added a commit
to iceteaSA/opencode
that referenced
this pull request
Jul 2, 2026
This was referenced Jul 6, 2026
ualtinok
force-pushed
the
fix/filter-compacted-history-load
branch
from
3a47cb4 to
b17491c
Compare
July 7, 2026 08:56
iceteaSA
added a commit
to iceteaSA/opencode
that referenced
this pull request
Jul 8, 2026
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Jul 10, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Closed
6 tasks
ualtinok
force-pushed
the
fix/filter-compacted-history-load
branch
from
b17491c to
0e96d57
Compare
July 15, 2026 07:18
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Jul 17, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6 tasks
randomvariable
added a commit
to randomvariable/opencode
that referenced
this pull request
Aug 3, 2026
Factor the compaction filter into an incremental scan and have filterCompactedEffect page backward through messages, stopping as soon as a completed compaction boundary (and any retained tail) is found, instead of hydrating the entire session history first. Ported from anomalyco#31638 (already Effect-based; applied as-is). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
|
Cross-linking: PR #39930 (brauliobo, July 31) implements the same fix for the same function (filterCompactedEffect), with a leaner approach worth considering before merging either:
Recommendation: consolidate on #39930 (or port its messageRows-first walk into #31638's shared scan-state structure — that combination is the best of both). Having both open means one will likely be closed as a duplicate by the maintainers anyway. |
Sorry, something went wrong.
iceteaSA
added a commit
to iceteaSA/opencode
that referenced
this pull request
Aug 29, 2026
Upstream PR anomalyco#39930 by @brauliobo, ported onto current dev. Finds the compaction boundary from lightweight message rows first, then hydrates only the retained messages, so oversized parts on the boundary page are never hydrated. Supersedes upstream PR anomalyco#31638 by @ualtinok, which this branch previously carried. The two are competing rewrites of the same function and conflict. Verified 2026-08-28: anomalyco#31638's full pagination test file passes against this implementation, while this PR's boundary-hydration test fails against anomalyco#31638's. Co-authored-by: Braulio Oliveira <brauliobo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22208
Related: #31525, #25366, #24841, #31527
Type of change
What does this PR do?
MessageV2.filterCompactedEffect(sessionID) used to stream the entire session history, then discard messages before the latest completed compaction boundary.
This changes the DB-backed path to page newest-first and stop once the compacted boundary has been found. The in-memory filterCompacted(...) behavior is kept shared through the same scan state, so the returned message list stays equivalent without hydrating pre-compaction history from the database.
Unlike #31527, this does not cache messages across prompt-loop iterations. It only reduces the amount of history loaded for already-compacted sessions.
How did you verify your code works?
Screenshots / recordings
N/A — backend performance fix.
Checklist