The following comment was made by an LLM, it may be inaccurate:

I found one potentially related PR:

PR #31256: feat(app): add ability to edit WSL credentials + redesign of the server tab
#31256

This PR addresses WSL functionality and server tab redesign, which overlaps with the current PR's WSL UI focus. While the current PR (34233) is specifically about the new WSL UI with loading states and a loader component, PR #31256 also involves WSL credential editing and server tab changes. These could be related efforts, though they may address different aspects of the WSL feature.

All other results are either the current PR itself or unrelated PRs about other features.

Thanks for the update. I tested this PR against the current dev tip in a disposable merge worktree and I don't think it is safe to merge yet.

Validation that passed locally on the merged result:

• git merge origin/pr-34233 into latest origin/dev: clean merge, no conflicts
• git diff --check HEAD^1 HEAD: passed
• bun install --frozen-lockfile: passed
• bun run typecheck in packages/app: passed
• bun run typecheck in packages/ui: passed
• bun test --preload ./happydom.ts ./src/i18n/parity.test.ts ./src/wsl/settings-model.test.ts in packages/app: passed
• bun run build in packages/app: passed, with existing-style Vite bundle/dynamic-import warnings

Blockers to address before merge:

1. The WSL dialog sizing/layout selectors likely do not apply. DialogV2 applies the class prop to [data-slot="dialog-content"], not to the root [data-component="dialog-v2"]. The new CSS selectors in packages/app/src/wsl/dialog-add-wsl-server.css use patterns like [data-component="dialog-v2"].settings-v2-wsl-dialog [data-slot="dialog-container"], which require the class on the root element. This means the container/header/body/footer overrides for the new WSL dialogs are skipped.

2. Non-ready/loading dialog states lose the dialog title/accessibility wiring. packages/app/src/wsl/settings.tsx now pushes DialogAddWslServer directly instead of wrapping it in a DialogHeader/DialogTitle. In packages/app/src/wsl/dialog-add-server.tsx, the loading fallbacks render only an aria-hidden LoaderV2, and DialogWslSetup renders a plain h2 instead of DialogTitle, so those dialog states do not have the Kobalte dialog title/accessibility association that the ready state has.

3. Loading buttons remain enabled in the DOM. The install/add buttons switch to variant="loading" while their disabled prop becomes false during loading. The loading CSS then disables pointer events and removes the focus outline for [data-variant="loading"], leaving a keyboard-focusable/activatable icon-only button state with no visible focus indication. Please use real disabled or proper aria-disabled/aria-busy behavior while preserving the fixed-width loading layout.

Additional policy state: GitHub shows all current PR checks green and no conflicts, but there are no submitted reviews yet and requested reviewers are still pending. The PR branch is also 12 commits behind current dev; I did not see overlap with the WSL files in that delta, but please update if branch freshness is required for merge.

I re-ran the merge review against current dev in a disposable worktree. This still should not merge yet.

Fresh validation on origin/dev + this PR:

• Clean local merge into current origin/dev (61a7f6db), no conflicts.
• GitHub checks are green.
• git diff --check HEAD^1..HEAD: passed.
• bun install --frozen-lockfile: passed.
• bun run --cwd packages/app typecheck: passed.
• bun run --cwd packages/ui typecheck: passed.
• bun test --preload ./happydom.ts ./src/wsl: passed.
• bun test src/main/wsl/servers.test.ts in packages/desktop: passed.
• bun run --cwd packages/app build: passed, with existing Vite warnings.
• bun run --cwd packages/ui build: passed.

Additional blockers found in this pass:

1. The new automatic addable-distro probing can retry forever after a failed probe. needsAddableProbe() remains true while a distro/opencode probe is missing, probeAllAddable() catches the error and resets probingDistros to false, then the effect immediately re-enters the same failing probe path. Please add failure/backoff state or a lastAutoProbe-style guard for addable probes.

2. The first-run distro recovery path was removed. The UI still tells users to open a distro once when probe.canExecute is false, but the primary action is disabled for non-ready distros and the dialog no longer exposes the previous api.openTerminal() action. That leaves users dead-ended in the dialog for this recoverable state. Please reintroduce an "Open terminal" action or equivalent recovery path.

The earlier blocker comment also still applies: the WSL dialog CSS selectors target the dialog root even though DialogV2 applies class to dialog-content, setup/loading states lack proper DialogTitle wiring, and the ButtonV2 loading variant is visual-only rather than semantically disabled/busy.

Branch freshness: the PR branch is based on f5a0b920; current dev is 61a7f6db (14 commits ahead). I saw no overlap in those 14 commits with this PR's touched WSL/UI files, and the local merge is clean.

Rechecked this PR against the current dev tip and I still do not think it is safe to merge.

Current merge state:

• Current dev: dfeb1b5051a05b359bd4af711b204d2c0342c5f4
• PR head: 46d4669fb9bf73035565e2ea45ae8aff73d502d5
• Local current-tip merge: c3f8865d54511f606385a0a137b2109819eae7b9, clean/no conflicts
• GitHub checks are green, but there are still no submitted reviews.

Validation passed on the local current-tip merge:

• git diff --check HEAD^1..HEAD
• bun install --frozen-lockfile
• bun run --cwd packages/app typecheck
• bun run --cwd packages/ui typecheck
• bun test --preload ./happydom.ts ./src/wsl in packages/app
• bun run --cwd packages/app build (existing Vite warnings only)
• bun run --cwd packages/ui build

Merge blockers still present:

1. Failed addable WSL probes can retry forever. needsAddableProbe() stays true while a distro/opencode probe entry is missing (packages/app/src/wsl/dialog-add-server.tsx lines 242-251). probeAllAddable() catches the error and resets probingDistros to false (lines 272-280), then the effect immediately calls it again (lines 284-286). Please add failure/backoff state or another guard so one failed probe does not spin WSL IPC and repeated toasts.

2. The recoverable "open distro once" path is gone. The UI still tells users to open the distro once when probe.canExecute is false (dialog-add-server.tsx line 120), but the primary button is disabled with no action for non-ready distros (lines 159-166) and this dialog no longer calls api.openTerminal(...). Users can be dead-ended in a state the UI presents as recoverable.

3. Loading buttons are visually disabled but semantically enabled and lose their accessible name. The catalog/install and primary buttons switch to variant="loading" while disabled becomes false (dialog-add-server.tsx lines 458-466 and 561-569). Their text is replaced by LoaderV2, whose default is aria-hidden, while button-v2.css uses pointer-events: none and removes the focus outline for loading buttons (packages/ui/src/v2/components/button-v2.css lines 31 and 154-160). Please use real disabled or correct aria-disabled/aria-busy semantics while preserving the fixed loading layout/name.

4. Some dialog states are not properly titled/labeled. DialogWslSetup renders a plain <h2> instead of DialogTitle (dialog-add-server.tsx lines 601 and 627), so Kobalte will not wire aria-labelledby. The loading/error fallback dialogs also render without DialogTitle (lines 375-384 and 402-406). Additionally, when state === "unavailable" and installable is false, both the install and close actions are hidden (lines 633-645), leaving no visible action.

5. The WSL dialog sizing CSS selectors still target the wrong element. DialogV2 applies the class prop to [data-slot="dialog-content"], not to the root [data-component="dialog-v2"] (packages/ui/src/v2/components/dialog-v2.tsx lines 85-97). Selectors such as [data-component="dialog-v2"].settings-v2-wsl-dialog [data-slot="dialog-container"] in packages/app/src/wsl/dialog-add-wsl-server.css therefore do not match the intended root/container/header/footer overrides.

An independent adversarial reviewer also recommended blocking merge, specifically confirming the probe retry loop, loading-button accessibility issue, and setup dialog labeling/action issue. Please add focused coverage for failed probe retry behavior, loading button semantics, and unavailable/setup dialog rendering before another merge attempt.

Rechecked this PR against the current dev tip. I am not merging it yet because merge blockers are still present.

Current state:

• Base checked locally: origin/dev 6ee817d0416cc902bdf1e05b0a3db1e94d07434a
• PR head: 46d4669fb9bf73035565e2ea45ae8aff73d502d5
• Local merge into current origin/dev: clean, no conflicts
• GitHub shows MERGEABLE / CLEAN; all PR checks are green
• Branch rules require unit (linux), unit (windows), e2e (linux), e2e (windows), and typecheck; strict current-base checks are not required; no approving-review count is required
• Review status is still no submitted reviews, with requested reviewers pending

Validation passed on the local current-tip merge:

• bun install
• bun typecheck in packages/app
• bun typecheck in packages/ui
• bun test src --only-failures in packages/ui
• bun run test:unit in packages/app
• git diff --cached --check

Blockers:

1. Failed addable WSL probes can still loop. needsAddableProbe() stays true while probe data is missing (packages/app/src/wsl/dialog-add-server.tsx lines 242-251), and probeAllAddable() clears probingDistros after errors (lines 272-280), so the effect at lines 284-286 can immediately re-enter the same failing probe path.

2. The recoverable "open distro once" path is still missing. The UI tells users to open a distro once (dialog-add-server.tsx line 120), but the primary action is disabled for non-ready distros (lines 159-166) and this dialog no longer exposes api.openTerminal(...).

3. OpenCode probe errors can render as Ready. distroStatus() does not account for check.error before returning ready (dialog-add-server.tsx lines 125-136), while opencodeReady() correctly treats errors as not ready. That can show a ready row with a blocked/add-disabled primary path.

4. Loading buttons are visually disabled but not semantically safe. The catalog and primary buttons replace their accessible text with an aria-hidden loader (dialog-add-server.tsx lines 464-466 and 567-569; packages/ui/src/v2/components/loader-v2.tsx line 17), while button-v2.css suppresses focus styling and pointer interaction for [data-variant="loading"]. Please keep a button name and use proper disabled, aria-disabled, or aria-busy semantics.

5. Non-ready dialog states are still not properly titled/labeled. Loading/error fallback dialogs render without DialogTitle (dialog-add-server.tsx lines 375-384 and 402-406), and DialogWslSetup uses a plain h2 instead of DialogTitle (line 627). Also, the unavailable/non-installable setup state hides both install and close actions (lines 633-645).

6. The WSL dialog sizing selectors still appear to target the wrong element. DialogV2 applies the passed class to [data-slot="dialog-content"], but selectors in packages/app/src/wsl/dialog-add-wsl-server.css use [data-component="dialog-v2"].settings-v2-wsl-dialog ..., so the intended container/header/footer overrides do not match.

An independent adversarial reviewer also recommended blocking merge, confirming the missing first-launch recovery path, unlabeled dialog states, loading-button accessible-name issue, and the OpenCode probe-error status mismatch. Please address these with focused coverage before another merge attempt.