FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(app): repair malformed persisted tabs by OpeOginni · Pull Request #39645 · anomalyco/opencode · GitHub

/ opencode Public

fix(app): repair malformed persisted tabs - #39645

Merged
Brendonovich merged 2 commits into
anomalyco:devfrom
OpeOginni:fix-tab-hydration
Jul 30, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix(app): repair malformed persisted tabs#39645
Brendonovich merged 2 commits into
anomalyco:devfrom
OpeOginni:fix-tab-hydration

Conversation

OpeOginni commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue for this PR

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

  • Filters null and malformed entries while persisted tabs are hydrated.
  • Keeps valid session and draft tabs, including legacy tabs that need the fallback server.
  • Prevents desktop startup crashes when tab consumers read the type field.

Possible Inputs:

null
// => []

[null]
// => []

[{ type: "session", sessionId: "abc" }]
// => [{ type: "session", sessionId: "abc", server: fallback }]

[{ type: "session", server: null, sessionId: "abc" }]
// => []

[{ type: "session", server: "local", sessionId: "abc" }]
// => preserved

[{ type: "draft", server: "local", draftID: "1" }]
// => removed because directory is missing

[{ type: "unknown", server: "local" }]
// => []

How did you verify your code works?

  • Ran bun test --preload ./happydom.ts ./src/context/tabs.test.ts from packages/app.
  • Ran bun typecheck from packages/app.
  • Added regression coverage for null entries, malformed tabs, invalid top-level data, and legacy tabs.

Screenshots / recordings

  • Not applicable; this changes persisted-state hydration without changing the UI.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Brendonovich merged commit ac53806 into anomalyco:dev Jul 30, 2026
2 checks passed
3kaiu pushed a commit to 3kaiu/opencode-x that referenced this pull request Jul 31, 2026
fix(app): repair malformed persisted tabs (anomalyco#39645)
70ce73a
1056674754 added a commit to 1056674754/opencode that referenced this pull request Aug 5, 2026
chore: merge OpenCode v1.18.10-sscity
52265a9 
Upstream v1.18.9 (4da7bb4) -> v1.18.10 (7902e04), 24 commits.

Functional changes:
- feat: discover Modal models (anomalyco#39066) - new packages/opencode/src/plugin/modal/
- fix: use OpenCode model catalog URL (anomalyco#39672) - models.dev -> models.opencode.ai
- fix(app): repair malformed persisted tabs (anomalyco#39645)
- fix(app): defer model variant selector (anomalyco#39445)
- fix(app): preserve agent picker for existing users (anomalyco#39300)
- feat(app): migrate to solid-sonner (anomalyco#39519)
- feat(app): attachment fades, duplicate guard, always-visible new session button
- feat(app): review tab top bar + tab state refinements
- fix(console): add public fetch compatibility flag
- docs(ecosystem): add opencode-tavily plugin (anomalyco#38709)
- chore: bump gitlab-ai-provider to 6.12.1 (anomalyco#39490)

Conflicts resolved: 29 package.json version bumps (rebranded 1.18.10-sscity)
and bun.lock (regenerated). No functional code conflicts.

Verified: Modal plugin tests pass (2/2), model catalog URL applied to all
3 files, fork-only changes (small_model_fallback, skill hot-reload, server
single-flight) intact. Pre-existing TUI type errors unrelated to this merge.
banlanzs pushed a commit to banlanzs/opencode that referenced this pull request Aug 6, 2026
fix(app): repair malformed persisted tabs (anomalyco#39645)
4b7e593
charlesverge pushed a commit to charlesverge/opencode that referenced this pull request Aug 11, 2026
fix(app): repair malformed persisted tabs (anomalyco#39645)
93a574a
moonug pushed a commit to moonug/opencode that referenced this pull request Aug 19, 2026
fix(app): repair malformed persisted tabs (anomalyco#39645)
0bc943f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Hona Awaiting requested review from Hona Hona is a code owner
Brendonovich Awaiting requested review from Brendonovich Brendonovich is a code owner

Assignees

No one assigned

Labels

contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash on desktop startup from null persisted tab

2 participants

Back | FazBrowse Home | New Git URL