fix(session): stop retrying fixed-window usage quotas - #39791
Open
vinlee19 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Long-window usage quota responses cannot succeed before their reset, so retrying them creates repeated requests and leaves sessions waiting unnecessarily.\n\nTreat 5-hour, weekly, and monthly quota 429s as terminal whether the provider exposes the detail in the message or response body. Preserve retries for short-window rate limits.\n\nFixes anomalyco#39790
Copy link
Copy Markdown
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related open PR: Related PR (not a duplicate):
The current PR (#39791) is specifically about stopping retries for fixed-window usage quotas where retry is futile, whereas #38958 focuses on capping the total number of retries across all scenarios. No duplicate PRs found |
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39790
Type of change
What does this PR do?
Stops retrying 429 responses for known long-window usage quotas (5-hour, weekly, or monthly) because another request cannot succeed before the reset. The check uses both the provider message and retained response body.
Short-window rate limits continue through the existing retry path. This complements the general retry cap proposed in #38958 by ending known terminal quota responses immediately.
How did you verify your code works?
The regression tests cover the observed 5-hour response, quota text retained only in responseBody, and a per-minute quota that must remain retryable.
Screenshots / recordings
N/A
Checklist