FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ai): safely replay unsigned Bedrock reasoning by opencode-agent[bot] · Pull Request #45765 · anomalyco/opencode · GitHub

fix(ai): safely replay unsigned Bedrock reasoning - #45765

Merged
neriousy merged 1 commit into
v2from
bedrock-unsigned
Aug 27, 2026
Merged

fix(ai): safely replay unsigned Bedrock reasoning#45765
neriousy merged 1 commit into
v2from
bedrock-unsigned

Conversation

Copy link
Copy Markdown
Contributor

Issue for this PR

V2 follow-up to #45621. This changes the native Bedrock Converse adapter, not V1 or the Vercel SDK dependency.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Unsigned reasoning can reach the Bedrock adapter after a model switch or from incomplete history without a recorded error. The adapter currently sends it as reasoningContent without a usable signature.

Demote readable unsigned reasoning to ordinary text, preserving its cache hint, as the Anthropic adapter already does. Drop blank unsigned reasoning and omit assistant messages left empty. Signed and redacted reasoning remain unchanged, without cache points appended to those blocks.

How did you verify your code works?

  • Eight new request-compilation regressions failed before the fix and pass afterward: missing/empty/whitespace signatures with automatic caching on/off, empty reasoning with cache hints, and mixed foreign/signed/redacted reasoning plus text and tools.
  • Bedrock Converse, Bedrock cache replay, and Anthropic Messages suites: 122 passed.
  • Core history conversion and interrupted-reasoning continuation checks: 24 passed.
  • AI package typecheck, formatting, and git diff --check passed.
  • Full AI suite: 789 passed, 25 skipped, 17 failed. Untouched base 5d4ce14dc4 has the identical 17 failing test names (781 passed, 25 skipped); those existing failures are not changed here.
  • No live Bedrock request was made; validation uses local wire-shape assertions and existing fixtures.

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Requested by: @neriousy (Filip via Slack)

neriousy merged commit 3288a12 into v2 Aug 27, 2026
10 checks passed
neriousy deleted the bedrock-unsigned branch August 27, 2026 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL