fix(opencode): drop unsupported max reasoning effort - #49995
Open
muhammad-fiaz wants to merge 1 commit into
Open
muhammad-fiaz wants to merge 1 commit into
muhammad-fiaz wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Muse Spark via Go/Zen advertises max yet 400s with invalid_request_error. Agent-level reasoningEffort max was forwarded to any selected model, failing turn 1. Clamp max for OpenAI-family even when advertised; drop stale efforts not in model variants; preserve xhigh and valid DeepSeek/GLM max. Closes anomalyco#47975
Copy link
Copy Markdown
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47975
Type of change
What does this PR do?
Muse Spark via Go/Zen advertises max yet rejects it with invalid_request_error. Agent-level reasoningEffort: max was forwarded to any selected model, failing turn 1.
Drops max for OpenAI-family even when advertised, drops stale efforts not in model.variants, preserves xhigh and valid DeepSeek/GLM max. Matches native OpenAIReasoningEfforts rejection.
How did you verify your code works?
Screenshots / recordings
N/A
Checklist