fix(core): add dispose functions to prevent subscription memory leaks by hendem · Pull Request #7032 · anomalyco/opencode · GitHub

Summary

Add dispose() functions to Share, ShareNext, Plugin, and Format namespaces to clean up Bus subscriptions
Add cleanupSession() and dispose() to ACP Agent for event subscription cleanup using AbortControllers
Add Bus._getSubscriptionCount() and Bus._getTotalSubscriptionCount() test helpers
Add memory tests to verify subscription cleanup works correctly

Problem

Bus subscriptions were accumulating during extended use because the return values from Bus.subscribe() were being ignored. Over time, this caused memory growth that could contribute to Bun running out of memory.

Solution

Each module that subscribes to Bus events now:

Stores the unsubscribe function returned by Bus.subscribe()
Provides a dispose() function that calls all stored unsubscribe functions

For ACP Agent specifically, session-scoped subscriptions use AbortControllers so they can be cleaned up when a session ends.

Testing

Added 10 unit tests in test/memory/ that verify:

Each module's dispose() properly unsubscribes
Multiple init/dispose cycles don't leak subscriptions
ACP session cleanup works correctly

All tests pass: bun test test/memory/

The following comment was made by an LLM, it may be inaccurate:

Summary

No duplicate PRs found.

All searches returned only PR #7032 (the current PR), with one additional unrelated result about Intent abstraction (PR #6549).

The searches covered:

Dispose functions and subscription cleanup keywords
Bus subscription and unsubscribe operations
Memory leak and subscription accumulation terminology
AbortController and session cleanup patterns
The specific namespaces (Share, ShareNext, Plugin, Format)
ACP Agent cleanup logic
Related issue references (Memory stays unbounded: ACP session map + compacted tool outputs #4315, opencode eating 70gb of memory? #5363)

This appears to be a unique PR addressing subscription memory leaks through new dispose functionality.

Pull request overview

This PR adds dispose() functions to multiple namespaces to prevent Bus subscription memory leaks that were causing Bun to run out of memory during extended use. The implementation adds cleanup mechanisms for Share, ShareNext, Plugin, and Format modules, along with AbortController-based session cleanup for the ACP Agent.

Key Changes:

Added dispose() functions that unsubscribe from Bus events across Share, ShareNext, Plugin, and Format namespaces
Implemented AbortController-based cleanup for ACP Agent session event subscriptions
Added Bus test helpers _getSubscriptionCount() and _getTotalSubscriptionCount() for testing

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/opencode/src/bus/index.ts	Added internal test helper functions to query subscription counts
packages/opencode/src/share/share.ts	Added subscriptions array and dispose() function to clean up Bus subscriptions and pending queue
packages/opencode/src/share/share-next.ts	Added subscriptions array and dispose() function to clean up Bus subscriptions and queued timeouts
packages/opencode/src/plugin/index.ts	Added subscriptions array and dispose() function to clean up wildcard event subscriptions
packages/opencode/src/format/index.ts	Added subscriptions array and dispose() function to clean up File.Event.Edited subscriptions
packages/opencode/src/acp/agent.ts	Added sessionAbortControllers map, cleanupSession() and dispose() methods to manage session-scoped event subscriptions using AbortControllers
packages/opencode/test/memory/subscription-cleanup.test.ts	Added comprehensive unit tests verifying dispose functions work correctly for all modules
packages/opencode/test/memory/profile.ts	Added memory profiling script to validate no memory leaks occur during init/dispose cycles
packages/opencode/test/memory/acp-cleanup.test.ts	Added tests for ACP Agent session cleanup and AbortController management

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

All Copilot review feedback has been addressed:

Share/ShareNext/Format init() accumulating subscriptions - Fixed in commit 7169a511: init() now calls dispose() at the start to clean up existing subscriptions before re-initializing.
ACP event subscription errors silently ignored - Fixed in commit 7169a511: Added .catch() handler to log errors from the subscription promise chain.
ACP race condition in finally block - Fixed in commit 7169a511: Added if (current === controller) check before deleting to prevent the race condition.
Test doesn't verify queue cleanup - Fixed in commit 158dcf70: Added _getQueueSize() helper and assertion to verify the queue is cleared after dispose().

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Have Instance.state dispose callbacks delegate to exported dispose() functions to avoid duplication - Reorder init() to call dispose() before getting state reference for clearer semantics - Add afterAll cleanup in subscription-cleanup.test.ts to clean up temp directory - Wrap profile.ts test functions in Instance.provide for proper Instance context - Add closed property to ACP mock in profile.ts

- Perform Instance.state dispose cleanup inline to prevent state() reinitialization during Instance disposal - Add AbortController to cancel in-flight fetch requests during dispose - Pass abort signal to SDK event.subscribe to properly cancel SSE stream - Update comments to accurately reflect full dispose behavior - Add proper async generator cleanup in test

…and adding abort checks

This PR has been superseded by #7914, which is a clean re-implementation on current dev (this PR had merge conflicts that were complex to resolve).

The new PR includes the same functionality:

dispose() for Share, ShareNext, Plugin, Format namespaces
AbortController-based cleanup for ACP Agent
Memory tests verifying cleanup

Leaving this PR open per request, but #7914 should be reviewed instead.

- Add dispose() to Share, ShareNext, Plugin, and Format namespaces - Add cleanupSession() and dispose() to ACP Agent with AbortControllers - Add Bus._getSubscriptionCount() test helpers - Add memory tests to verify cleanup works correctly Supersedes anomalyco#7032 Fixes anomalyco#3013

Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR.

Copilot AI review requested due to automatic review settings January 6, 2026 04:30

Copilot started reviewing on behalf of hendem January 6, 2026 04:30 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

hendem marked this pull request as draft January 6, 2026 04:40

hendem marked this pull request as ready for review January 6, 2026 04:45

This was referenced Jan 6, 2026

fix: add cleanup mechanisms to prevent memory leaks #7039

Closed

fix: wire up ACP agent cleanup on connection end to prevent memory leaks #7043

Closed

fix: clean up pending permissions when session is deleted #7154

Closed

hendem requested a review from Copilot January 7, 2026 03:54

Copilot started reviewing on behalf of hendem January 7, 2026 03:55 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/opencode/src/acp/agent.ts

Comment thread packages/opencode/src/acp/agent.ts

hendem requested a review from Copilot January 7, 2026 04:17

Copilot started reviewing on behalf of hendem January 7, 2026 04:17 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/opencode/test/memory/acp-cleanup.test.ts

Comment thread packages/opencode/src/share/share.ts Outdated

hendem requested a review from Copilot January 7, 2026 04:30

Copilot started reviewing on behalf of hendem January 7, 2026 04:30 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/opencode/src/acp/agent.ts Outdated

Comment thread packages/opencode/test/memory/acp-cleanup.test.ts

Comment thread packages/opencode/src/acp/agent.ts

Comment thread packages/opencode/src/acp/agent.ts

Comment thread packages/opencode/src/share/share.ts Outdated

hendem requested a review from Copilot January 7, 2026 04:45

Copilot started reviewing on behalf of hendem January 7, 2026 04:46 View session

Copilot AI reviewed Jan 7, 2026

hendem requested a review from Copilot January 7, 2026 15:30

Copilot started reviewing on behalf of hendem January 7, 2026 15:30 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/opencode/src/acp/agent.ts

Comment thread packages/opencode/src/share/share-next.ts Outdated

Comment thread packages/opencode/src/acp/agent.ts

Comment thread packages/opencode/test/memory/acp-cleanup.test.ts Outdated

hendem requested a review from Copilot January 7, 2026 15:42

Copilot started reviewing on behalf of hendem January 7, 2026 15:43 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Comment thread packages/opencode/src/acp/agent.ts

hendem requested a review from Copilot January 7, 2026 15:48

Copilot started reviewing on behalf of hendem January 7, 2026 15:48 View session

Mark Henderson added 5 commits January 10, 2026 14:16

fix: set disposed flag during cleanup before resetting for re-init

ecb66e6

fix: address race conditions by moving disposed flag reset to init() …

434ac09

…and adding abort checks

docs: clarify inline cleanup comment per review feedback

0bcf7bb

fwang force-pushed the fix/memory-leak-subscription-cleanup branch from f5297c8 to 0bcf7bb Compare January 10, 2026 19:16

hendem mentioned this pull request Jan 12, 2026

fix(core): add dispose functions to prevent subscription memory leaks #7914

Closed

This was referenced Jan 24, 2026

fix(opencode): memory leaks in session handling #10392

Closed

fix(opencode): resolve multiple memory leaks in long-running sessions #10914

Closed

thdxr force-pushed the dev branch from cbab81f to 2d3c7a0 Compare January 30, 2026 04:50

opencode-agent Bot force-pushed the dev branch from 00637c0 to 71e0ba2 Compare January 30, 2026 14:32

thdxr force-pushed the dev branch 3 times, most recently from f1ae801 to 08fa7f7 Compare January 30, 2026 14:37

github-actions Bot mentioned this pull request Feb 4, 2026

fix(memory): resolve 6 memory leak issues in long-running sessions #12053

Closed

github-actions Bot mentioned this pull request Feb 13, 2026

fix: resolve multiple memory leaks causing unbounded RAM growth ( Now passing: && Fixed failing tests for windows ) #13514

Closed

This was referenced Feb 22, 2026

fix: cleanup SDK event listeners to prevent memory leaks #14635

Closed

fix: consolidate memory leak fixes from #14650 and #8953 #15435

Closed

github-actions Bot mentioned this pull request Mar 2, 2026

fix: prevent memory leaks from SSE streams, LSP, Bus, and process cleanup #15646

Closed

6 tasks

binarydoubling mentioned this pull request Mar 9, 2026

Multiple memory leaks cause unbounded RAM growth during extended TUI usage #16697

Closed

github-actions Bot closed this Mar 13, 2026

fix(core): add dispose functions to prevent subscription memory leaks by hendem · Pull Request #7032 · anomalyco/opencode · GitHub

Uh oh!

fix(core): add dispose functions to prevent subscription memory leaks - #7032

fix(core): add dispose functions to prevent subscription memory leaks#7032hendem wants to merge 15 commits intoanomalyco:devanomalyco/opencode:devfrom hendem:fix/memory-leak-subscription-cleanuphendem/opencode:fix/memory-leak-subscription-cleanupCopy head branch name to clipboard

Conversation

hendem commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Problem

Solution

Testing

Uh oh!

github-actions Bot commented Jan 6, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hendem commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

hendem commented Jan 12, 2026

Uh oh!

github-actions Bot commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(core): add dispose functions to prevent subscription memory leaks#7032
hendem wants to merge 15 commits into
anomalyco:devfrom
hendem:fix/memory-leak-subscription-cleanup

hendem commented Jan 6, 2026 •
edited
Loading