FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add signature field to ReasoningPart by iso2kx · Pull Request #7222 · anomalyco/opencode · GitHub

/ opencode Public

fix: Add signature field to ReasoningPart - #7222

Closed
iso2kx wants to merge 1 commit into
anomalyco:devfrom
iso2kx:fix/add-signature-to-reasoning-part
ConversationCommits (1)ChecksFiles changed
Closed

fix: Add signature field to ReasoningPart#7222
iso2kx wants to merge 1 commit into
anomalyco:devfrom
iso2kx:fix/add-signature-to-reasoning-part

Conversation

iso2kx commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

This PR adds the optional signature field to the ReasoningPart type to support thinking block signatures required by models like Claude.

Changes

  • Added signature: z.string().optional() to ReasoningPart in packages/opencode/src/session/message-v2.ts
  • Added signature: z.string().optional() to ReasoningPart in packages/opencode/src/session/message.ts
  • Updated toModelMessage function to include the signature when converting reasoning parts

Related Issue

Fixes issue #6418: "Error: Invalid signature in thinking block" when switching models from MiniMax/GLM to Claude

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found:

Why they're related: Both PRs address compatibility issues when switching between different models and handling thinking/reasoning blocks. PR #6748 handles stripping incompatible thinking blocks when switching to Anthropic models, while PR #7222 adds signature field support for Claude. These changes may be related to the same issue (#6418) about model compatibility with thinking blocks.

iso2kx commented Jan 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #6748 which provides a more complete fix - stripping incompatible thinking blocks and converting reasoning to text when switching to Anthropic models.

iso2kx closed this Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL