馃И馃敟 Delete the egg-info integration test - #84686
Merged
webknjaz merged 1 commit intoFeb 7, 2025
Merged
webknjaz merged 1 commit into
webknjaz merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes ansible#84681. [1]: ansible#84681 (comment)
mattclay
approved these changes
Feb 7, 2025
webknjaz
added a commit
that referenced
this pull request
Feb 10, 2025
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes #84681. [1]: #84681 (comment) (cherry picked from commit ee49adf) Co-authored-by: 馃嚭馃嚘 Sviatoslav Sydorenko (小胁褟褌芯褋谢邪胁 小懈写芯褉械薪泻芯) <webknjaz@redhat.com>
webknjaz
added a commit
that referenced
this pull request
Feb 10, 2025
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes #84681. [1]: #84681 (comment) (cherry picked from commit ee49adf) Co-authored-by: 馃嚭馃嚘 Sviatoslav Sydorenko (小胁褟褌芯褋谢邪胁 小懈写芯褉械薪泻芯) <webknjaz@redhat.com>
webknjaz
added a commit
that referenced
this pull request
Feb 10, 2025
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes #84681. [1]: #84681 (comment) (cherry picked from commit ee49adf) Co-authored-by: 馃嚭馃嚘 Sviatoslav Sydorenko (小胁褟褌芯褋谢邪胁 小懈写芯褉械薪泻芯) <webknjaz@redhat.com>
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Feb 10, 2025
Previously, the integration test depended on luck. `setuptools` used to be bundled in Python stdlib's `ensurepip`. Python 3.12 and newer no longer include it. This test imports `pkg_resources` that is a part of `setuptools`, meaning that it'll run out of luck at some point, under newer Python runtimes. This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [[1]]. Supersedes ansible#84681. [1]: ansible#84681 (comment) (cherry picked from commit ee49adf)
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@webknjaz Why backport this? Is there some issue with the stable branches? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@mattclay my assumption was that we'd bump macos there which would hit the same issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
We generally don't backport new platforms or versions unless there's a good reason. The most common is updating an older FreeBSD version from X.Y to X.Y+N when the previous version no longer works in CI. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Ack |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the integration test depended on luck. setuptools used to be bundled in Python stdlib's ensurepip. Python 3.12 and newer no longer include it. This test imports pkg_resources that is a part of setuptools, meaning that it'll run out of luck at some point, under newer Python runtimes.
This test does not seem to be useful to us so instead of fixing it, we remove it from the repo [1].
Supersedes #84681.
SUMMARY
SSIA
ISSUE TYPE