GH-130: Fix AutoCloseables to work with @Nullable structures - #1017
Conversation
Sorry, something went wrong.
This comment has been minimized.
|
Please add the enhancement label. |
Sorry, something went wrong.
jbonofre
left a comment
There was a problem hiding this comment.
I don't have problem to add @Nullable. That said, I don't consider as a bug fix but more as improvement.
Sorry, something went wrong.
| */ | ||
| public static AutoCloseable all(final Collection<? extends AutoCloseable> autoCloseables) { | ||
| public static AutoCloseable all( | ||
| final @Nullable Collection<? extends @Nullable AutoCloseable> autoCloseables) { |
There was a problem hiding this comment.
I don't have problem to add @Nullable here.
Sorry, something went wrong.
| public static void close(Throwable t, AutoCloseable... autoCloseables) { | ||
| public static void close(Throwable t, @Nullable AutoCloseable... autoCloseables) { | ||
| if (autoCloseables == null) { | ||
| return; |
There was a problem hiding this comment.
That should not happen, but it seems you have a case ;)
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, they are saying it's not overly cautious.
https://stackoverflow.com/a/28271272/8269828
Sorry, something went wrong.
What's Changed
AutoCloseables supposes to work with nullable Iterables, varargs, and collection of nulls. The PR introduces:
The change is backward compatible. Only possible NPEs are prevented.
Closes #130 .