GH-470: [Vector] Fix ListViewVector.getElementEndIndex(index) method - #1019
Merged
jbonofre merged 2 commits intoFeb 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
axreldable
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
February 15, 2026 13:57
This comment has been minimized.
Copy link
Copy Markdown
Contributor
Author
|
Please add the bug-fix label. |
Sorry, something went wrong.
…(hashCode) and offsetBuffer with SIZE_WIDTH (setSize) plus refactoring to avoid code duplication in ListViewVector
axreldable
force-pushed
the
gh-470-get-end-index-list-view-1
branch
from
aec2975 to
ade73e5
Compare
February 16, 2026 19:29
jbonofre
approved these changes
Feb 17, 2026
jbonofre
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It looks good to me.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
First commit changes logic:
Before:
public int getElementEndIndex(int index) { return sizeBuffer.getInt(index * OFFSET_WIDTH); }After:
public int getElementEndIndex(int index) { return offsetBuffer.getInt(index * OFFSET_WIDTH) + sizeBuffer.getInt(index * SIZE_WIDTH); }Second commit doesn't change logic:
Fixes a bug of usage sizeBuffer with OFFSET_WIDTH (hashCode method) and offsetBuffer with SIZE_WIDTH (setSize method). It doesn't introduce real changes in the logic as OFFSET_WIDTH == SIZE_WIDTH == 4
Plus small refactoring of ListViewVector to avoid code duplication and similar issues in the future.
It's a bug fix.
Closes #470.