FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-1061: Add codegen classifier jar for arrow-vector. by lriggs · Pull Request #1062 · apache/arrow-java · GitHub

GH-1061: Add codegen classifier jar for arrow-vector. - #1062

Merged
jbonofre merged 5 commits into
apache:mainfrom
lriggs:codgenClassifier
Mar 11, 2026
Merged

GH-1061: Add codegen classifier jar for arrow-vector.#1062
jbonofre merged 5 commits into
apache:mainfrom
lriggs:codgenClassifier

Conversation

lriggs commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

What's Changed

Add a new codegen classifier jar for arrow-vector that contains tdd and other template files.

Closes #1061 .

lriggs changed the title GH-1061 Add codegen classifier jar for arrow-vector. GH-1061: Add codegen classifier jar for arrow-vector. Mar 9, 2026

This comment has been minimized.

lidavidm commented Mar 9, 2026

Copy link
Copy Markdown
Member

Can you explain how these are useful?

Copy link
Copy Markdown

Can you explain how these are useful?

Arrow's type system has many types, and projects building operations across Arrow data (comparisons, casts, aggregations) benefit from generating type-specialized code rather than hand-writing implementations for each type.

The TDD files provide a machine-readable definition of Arrow's types that enables this. Including them in the distribution allows downstream projects to generate code that stays in sync as Arrow's type system evolves.

Copy link
Copy Markdown
Member

Thanks! Can this rationale be documented in the code itself?

lriggs commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

I added a comment about the usefulness of the codegen files.

Copy link
Copy Markdown
Member

Ah, I would've expected it next to the build config, sorry for being unclear 😅

jbonofre added the enhancement PRs that add or improve features. label Mar 10, 2026

Copy link
Copy Markdown
Member

Thanks for the details @telemenar and @lriggs .

Can we add a note in the docs folder, quickly documenting this ?

It's a good enhancement to me, we should give a bit of context for the users 😄

jbonofre added this to the 19.0.0 milestone Mar 10, 2026

lriggs commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. I added a few notes.

jbonofre merged commit e349a9a into apache:main Mar 11, 2026
26 checks passed
lriggs added a commit to lriggs/arrow-java that referenced this pull request Mar 11, 2026
)

## What's Changed

Add a new codegen classifier jar for arrow-vector that contains tdd and
other template files.

Closes apache#1061 .
lriggs added a commit to dremio/arrow-java that referenced this pull request Mar 12, 2026
) (#20)

## What's Changed

Add a new codegen classifier jar for arrow-vector that contains tdd and
other template files.

Closes apache#1061 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that add or improve features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new classifier jar for arrow-vector tdd files

4 participants


Back | FazBrowse Home | New Git URL