GH-1067: Close cached HDFS FileSystem instances - #1141
Open
xborder wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
xborder
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
May 7, 2026 13:30
This comment has been minimized.
Copy link
Copy Markdown
Member
|
@xborder I fixed the CI on main. Can you please rebase? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry, probably need to rebase again. |
Sorry, something went wrong.
lidavidm
reviewed
Aug 25, 2026
Comment on lines
+73
to
+77
| try { | ||
| super.close(); | ||
| } finally { | ||
| hdfsFileSystems.forEach(FileSystemDatasetFactory::closeHadoopFileSystem); | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: could we use AutoCloseables here?
Sorry, something went wrong.
| Method closeMethod = fsClass.getMethod("close"); | ||
| closeMethod.invoke(fs); | ||
| } catch (Exception e) { | ||
| // Best-effort cleanup; Hadoop may not be on classpath or FileSystem already closed |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: worth perhaps logging this?
Sorry, something went wrong.
Comment on lines
+103
to
+104
| } catch (Exception e) { | ||
| // Ignore here; native factory creation reports invalid user URIs. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: could we catch a more specific exception class for invalid URIs?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Closes #1067 .