GH-834: Fix Avro nullable consumer to use readIndex for unions - #1147
Open
Kaustav-Sarkar wants to merge 1 commit into
Open
GH-834: Fix Avro nullable consumer to use readIndex for unions#1147Kaustav-Sarkar wants to merge 1 commit into
Kaustav-Sarkar wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Kaustav-Sarkar
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
May 13, 2026 12:48
Copy link
Copy Markdown
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Can a maintainer add labels, I do not have permission |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates Avro consumers to use readIndex() for unions and readString() for strings instead of readInt() and readBytes(). This ensures compatibility with Avro's ValidatingDecoder, which strictly enforces type-specific read methods. Includes a regression test for nullable strings.